-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Fixed issue with multiple validation triggers and resolved… #962
fix(core): Fixed issue with multiple validation triggers and resolved… #962
Conversation
… setTimeout memory leak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thanks!
Do you want to write a unit test to validate that?
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c40241. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 91.55% 88.43% -3.13%
==========================================
Files 21 26 +5
Lines 900 1072 +172
Branches 206 264 +58
==========================================
+ Hits 824 948 +124
- Misses 71 115 +44
- Partials 5 9 +4 ☔ View full report in Codecov by Sentry. |
@Balastrong Got it! 👾 |
I can't think of an easy way to test this in our current setup, and it clearly looks like a super clean PR so I'm gonna merge it. Please feel free to make another PR with tests if you can figure them out! :) Thanks for this! |
#905
While resolving this issue, I also fixed the repeated execution of setTimeout.