Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fixed issue with multiple validation triggers and resolved… #962

Merged

Conversation

rjsdnql123
Copy link
Contributor

#905

While resolving this issue, I also fixed the repeated execution of setTimeout.

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks!

Do you want to write a unit test to validate that?

Copy link

nx-cloud bot commented Oct 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c40241. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 1, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@962

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@962

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@962

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@962

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@962

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@962

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@962

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@962

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@962

commit: 1c40241

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (5473bb8) to head (1c40241).
Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   91.55%   88.43%   -3.13%     
==========================================
  Files          21       26       +5     
  Lines         900     1072     +172     
  Branches      206      264      +58     
==========================================
+ Hits          824      948     +124     
- Misses         71      115      +44     
- Partials        5        9       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsdnql123
Copy link
Contributor Author

@Balastrong Got it! 👾

@crutchcorn
Copy link
Member

I can't think of an easy way to test this in our current setup, and it clearly looks like a super clean PR so I'm gonna merge it. Please feel free to make another PR with tests if you can figure them out! :)

Thanks for this!

@crutchcorn crutchcorn merged commit 5e22635 into TanStack:main Oct 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants