-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle numeric keys as array index only if parent is an array #993
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e0154b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 91.55% 88.45% -3.11%
==========================================
Files 21 26 +5
Lines 900 1074 +174
Branches 206 265 +59
==========================================
+ Hits 824 950 +126
- Misses 71 115 +44
- Partials 5 9 +4 ☔ View full report in Codecov by Sentry. |
@maksymskuibida can you please validate that this fix works in your project? You can try the version of this PR with
|
I am sorry for late response. I just tested and it does not work. The same as it was before |
@maksymskuibida on the code sandbox you provided it seems to be working (make sure to stop the dev server and run If you have a more complete example where it's still broken please share it so I can give it another try :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests are passing, let's merge this. Don't let perfect be the enemy of better :)
Fixes #985