WIP: feat: add suspense to useQueries

[boschni]

Fixes #1523

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/kw4qlv2l7
✅ Preview: https://react-query-git-feature-use-queries-suspense.tannerlinsley.vercel.app

[tannerlinsley]

Anything I can do to help out here? Any questions?

[johnnyreilly]

Nice work!

I have a question. This adds the ability to specify generics for useQueries. Reading the code here, I think that this may fall into the "generic that is only used in the return position" anti-pattern category.

It's possible I'm reading it wrong so I wanted to ask a clarifying question: Does the approach here allow a user to specify types using the generic parameters that would differ from the return type of the query or of the select function?

If that's possible then the generics would not be adding a great deal of value as incorrectly typed data could still flow through.

Is that possible in this case?

As discussed, I'm generally keen on making use of type inference. But in the absence of that, avoiding type definitions that can possibly let incorrect types through is still worth aiming for.

[escaton]

@boschni do you need any help with this PR? I'm really looking forward to this feature and ready to help you finish it.

[tibi77]

@boschni do you need any help with this PR? I'm really looking forward to this feature and ready to help you finish it.

I would like to give a hand as well if there is a need.
I need this feature as well :D

[steevsachs]

@boschni We would also benefit from this fix, and I'd be happy to contribute if that'd be helpful.

@johnnyreilly It appears the original review just raised a question about the new type annotation. Is that the only outstanding change requested on this PR (besides conflict resolutions at this point : ))?

If no other changes are requested, I'd be happy to resolve the conflicts and revert the generics type change. Then @boschni can open a future change to re-add generics pending that discussion. Would that be ok?

[johnnyreilly]

Go for it!

[steevsachs]

Thanks for confirming. This merge turns out to be a bit of a doozy, but I should be able to get through it over this weekend.

[steevsachs]

@boschni @johnnyreilly Quick question as I work through what's amounting more to refactor of the fix than conflict resolution (given the amount of change to the target logic that's occurred since this was opened):

The fix here assumes useQueries should throw as a whole with the first error encountered, is that the expected behavior?

[escaton]

Talking about errors, my thought is that it should be configured with useErrorBoundary, not useSuspense.
But for consistency with useQuery i guess: yes it should throw with the first error.
https://github.com/tannerlinsley/react-query/blob/master/src/react/useBaseQuery.ts#L132

[steevsachs]

I've opened the new PR as #2109 due to the significant amount of change from this original PR. The commit in this PR is included in that PR. Please let me know if you'd prefer this be handled differently git-wise.

Requesting a very thorough review of this one, as it was significantly more complicated than I expected and my context as a contributor going in was basically nil. Please be brutal : ) I did confirm it working with a basic CRA and yarn link.