WIP: Monorepo, Rebrand to TanStack #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerlinsley
changed the title
it still errors with import/no-unresolved, but I think that's because TS errors as well!
not sure if that is correct now...
…y after upgrading react
I don't know what these tests are doing, but overwriting useEffect is not something that makes sense now that we useSyncExternalStore for data fetching anyways ...
rankItem doesn't take keys, so we have to pass the queryHash in directly to rank it
as requested by CI: Error: Package undefined in /tmp/98d7e7a6 is set to private, remove package.json#private to publish it
This reverts commit e1b237b.
somehow, that fails in CI, and we have typescript protection against unresolved imports anyhow
so we don't need to build during testing
it requires package to be public, but for installing and yarn workspaces, we need it to be private
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f654e9a:
|
Codecov Report
@@ Coverage Diff @@
## beta #3708 +/- ##
==========================================
- Coverage 97.11% 96.80% -0.32%
==========================================
Files 50 57 +7
Lines 2391 2659 +268
Branches 706 783 +77
==========================================
+ Hits 2322 2574 +252
- Misses 67 83 +16
Partials 2 2 Continue to review full report at Codecov.
|
prettier destroyed the assertions
this is likely a copy-paste error, and the tests only worked because we render top-down; now, the tests make sure that components are re-rendered because of the subscription itself
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.