Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devtools): Add move devtools select menu #4100

Merged
merged 3 commits into from
Oct 9, 2022

Conversation

salamaashoush
Copy link
Contributor

@salamaashoush salamaashoush commented Aug 29, 2022

closes #2994

Added the option to move dev tools to one of these sides left, right, top, and bottom and refactored the code to accommodate the new capability

@TkDodo sorry the previous PR got closed somehow when I updated my fork, I fixed your comments from the previous PR

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 29, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7803f1:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 11, 2022

can you please fix the merge conflicts? thanks

@TkDodo
Copy link
Collaborator

TkDodo commented Oct 7, 2022

any updates here @salamaashoush ? This feature would be really cool to have :)

@salamaashoush
Copy link
Contributor Author

@TkDodo I rebased the branch, and removed the isomorphic effect part

Added the option to move devtools to one of these sides `left`,  `right`, `top`, and `bottom` and refactored the code to accommodate the new capability
docs/devtools.md Outdated Show resolved Hide resolved
@salamaashoush salamaashoush changed the title feat: Add move devtools select menu feat(devtools): Add move devtools select menu Oct 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 96.36% // Head: 96.58% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (e7803f1) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4100      +/-   ##
==========================================
+ Coverage   96.36%   96.58%   +0.22%     
==========================================
  Files          45       86      +41     
  Lines        2281     3335    +1054     
  Branches      640      909     +269     
==========================================
+ Hits         2198     3221    +1023     
- Misses         80      112      +32     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/core/mutationObserver.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/core/query.ts
src/core/infiniteQueryObserver.ts
src/core/queryClient.ts
src/react/setBatchUpdatesFn.ts
src/react/logger.native.ts
src/react/useIsMutating.ts
src/core/queryObserver.ts
src/devtools/Logo.tsx
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit e6eaca6 into TanStack:main Oct 9, 2022
@salamaashoush salamaashoush deleted the move-devtools branch October 9, 2022 16:53
@TkDodo
Copy link
Collaborator

TkDodo commented Oct 11, 2022

This feature is really cool, thank you 🙏

One thing I was wondering: Do you think there is a way to make the devtools integrate with the app, so that it actually makes the viewport of the page smaller?

The floating is fine when being on the bottom, but as soon as I move it to a different position, it likely masks some of the content of my app 🤔

@TkDodo
Copy link
Collaborator

TkDodo commented Oct 11, 2022

wait a second, this actually works in codesandbox 😅 . Might be related to how we do layouting in our app then ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dev tools option
3 participants