-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devtools): Add move devtools select menu #4100
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e7803f1:
|
9f7b2ed
to
fa41ba3
Compare
can you please fix the merge conflicts? thanks |
any updates here @salamaashoush ? This feature would be really cool to have :) |
fa41ba3
to
81a6af8
Compare
@TkDodo I rebased the branch, and removed the isomorphic effect part |
Added the option to move devtools to one of these sides `left`, `right`, `top`, and `bottom` and refactored the code to accommodate the new capability
81a6af8
to
e089660
Compare
Codecov ReportBase: 96.36% // Head: 96.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4100 +/- ##
==========================================
+ Coverage 96.36% 96.58% +0.22%
==========================================
Files 45 86 +41
Lines 2281 3335 +1054
Branches 640 909 +269
==========================================
+ Hits 2198 3221 +1023
- Misses 80 112 +32
+ Partials 3 2 -1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This feature is really cool, thank you 🙏 One thing I was wondering: Do you think there is a way to make the devtools integrate with the app, so that it actually makes the viewport of the page smaller? The floating is fine when being on the bottom, but as soon as I move it to a different position, it likely masks some of the content of my app 🤔 |
wait a second, this actually works in codesandbox 😅 . Might be related to how we do layouting in our app then ... |
closes #2994
Added the option to move dev tools to one of these sides
left
,right
,top
, andbottom
and refactored the code to accommodate the new capability@TkDodo sorry the previous PR got closed somehow when I updated my fork, I fixed your comments from the previous PR