Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-query): Add compatibility with flat config #7663

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jul 2, 2024

Creating a recommended preset for flat config is a bit messy, as it needs to import the plugin itself. The ESLint docs show how to work around this here.

For some reason, ATTW generates a false-export-default warning. Since we distribute separate CJS and ESM source and types, this problem is avoided.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 0:10am

@github-actions github-actions bot added documentation Improvements or additions to documentation package: eslint-plugin-query labels Jul 2, 2024
Copy link

nx-cloud bot commented Jul 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6928cb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Jul 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6928cb8:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.46%. Comparing base (941ba88) to head (6928cb8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #7663       +/-   ##
=========================================
+ Coverage      0   44.46%   +44.46%     
=========================================
  Files         0      185      +185     
  Lines         0     7049     +7049     
  Branches      0     1547     +1547     
=========================================
+ Hits          0     3134     +3134     
- Misses        0     3552     +3552     
- Partials      0      363      +363     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (∅)
@tanstack/eslint-plugin-query 84.36% <0.00%> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (∅)
@tanstack/query-core 92.86% <ø> (∅)
@tanstack/query-devtools 5.24% <ø> (∅)
@tanstack/query-persist-client-core 57.73% <ø> (∅)
@tanstack/query-sync-storage-persister 82.50% <ø> (∅)
@tanstack/react-query 92.98% <ø> (∅)
@tanstack/react-query-devtools 10.71% <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (∅)
@tanstack/solid-query 78.06% <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (∅)
@tanstack/svelte-query 90.00% <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (∅)
@tanstack/vue-query 70.60% <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 98547b6 into main Jul 3, 2024
8 checks passed
@lachlancollins lachlancollins deleted the flat-config branch July 3, 2024 00:18
n0099 added a commit to n0099/open-tbm that referenced this pull request Aug 27, 2024
… @ `stores/relativeTime`

* switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js
@ fe
n0099 added a commit to n0099/open-tbm that referenced this pull request Aug 27, 2024
… @ `stores/relativeTime`

* switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js
@ fe
n0099 added a commit to n0099/open-tbm that referenced this pull request Aug 27, 2024
… @ `stores/relativeTime`

* switch to flat config as `@tanstack/eslint-plugin-query`: TanStack/query#7663, `eslint-plugin-pinia`: lisilinhart/eslint-plugin-pinia#35 & `eslint-plugin-import-x`: un-ts/eslint-plugin-import-x#122 now supports it @ eslint.config.js
@ fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation package: eslint-plugin-query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant