Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular persist query client experimental #8324

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Angular persist query client experimental #8324

wants to merge 38 commits into from

Conversation

OmerGronich
Copy link

@OmerGronich OmerGronich commented Nov 22, 2024 •
edited
Loading

Angular Query Persister Plugin

  • Created angular-query-persist-client-package
  • Implemented withPersistQueryClient in new package
  • Added isRestoring provider and injection token to main angular-query package

@OmerGronich OmerGronich marked this pull request as draft November 22, 2024 14:58
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch from 8474149 to 31c8c0e Compare November 22, 2024 15:01
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d80309. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 0ff5f5c to b4d880a Compare November 23, 2024 12:00
@OmerGronich OmerGronich deleted the angular-persist-query-client-experimental branch November 23, 2024 12:00
@OmerGronich OmerGronich restored the angular-persist-query-client-experimental branch November 23, 2024 12:00
@OmerGronich OmerGronich reopened this Nov 23, 2024
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch from 566f72a to e1ae58d Compare November 23, 2024 19:42
@OmerGronich OmerGronich marked this pull request as ready for review November 23, 2024 20:12
@arnoud-dv arnoud-dv self-assigned this Nov 26, 2024
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 2 times, most recently from d4fa95c to 9e4182a Compare November 29, 2024 13:27
arnoud-dv
arnoud-dv requested changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@arnoud-dv arnoud-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for now, I still need to do a more in-depth review of the persistence itself.

examples/angular/basic-persister/.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
examples/angular/basic-persister/package.json Outdated Show resolved Hide resolved
examples/angular/basic-persister/src/app/app.config.ts Show resolved Hide resolved
examples/angular/basic-persister/src/index.html Outdated Show resolved Hide resolved
examples/angular/basic-persister/tsconfig.json Show resolved Hide resolved
examples/angular/basic-persister/tsconfig.json Outdated Show resolved Hide resolved
examples/angular/basic-persister/tsconfig.json Show resolved Hide resolved
packages/angular-query-experimental/src/inject-is-restoring.ts Outdated Show resolved Hide resolved
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch 3 times, most recently from 3c3c8ec to ed0ed3c Compare December 7, 2024 14:40
@OmerGronich
feat(angular-query):
f327a5d 
- Created isRestoring injection token and provider
- handled restoration phase in create-base-query.ts
- handled restoration phase in
@OmerGronich
feat(angular-query): created package for experimental persistence sup…
dd92bfc 
…port, and the withPersistQueryClient feature
@OmerGronich
test(persistQuery): add tests for withPersistQueryClient
b8afd8a
@OmerGronich
docs(angular-query): add basic persister example
547ae9e
@OmerGronich
fix(angular-query): synced angular versions in new package
7130913
@OmerGronich
fix(angular-query): commit before ng update
5709184
@OmerGronich
feat(angular-query): updated example to v18
9e6ef24
@OmerGronich
fix(angular-query): fixed project name to basic-persister
962cf32
@OmerGronich
feat(angular-query): updated example basic-persister to v19
4d305a5
@OmerGronich
feat(angular-query): included back the persister package after angula…
630e462 
…r migration
OmerGronich and others added 18 commits December 7, 2024 22:44
@OmerGronich
feat(angular-query): migrate to provideEnvironmentInitializer
fed1caa
@OmerGronich
fix(angular-query): fix eslint issues in inject-queries.ts
63831fb
@OmerGronich
Revert "feat(angular-query): migrate to provideEnvironmentInitializer"
059b620 
This reverts commit af5b47b.
@OmerGronich
fix(angular-query): only track the isRestoring in the effect
05848e2
@OmerGronich
fix(angular-query): removed conditional _isRestoring
a0d3111
@autofix-ci @OmerGronich
ci: apply automated fixes
e2f579b
@OmerGronich
fix(angular-query): used effect onCleanup instead of destroy ref
929b114
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/.devcontainer/devcontainer.json
9dcdd1c 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/package.json
f208029 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/src/index.html
1d3c67a 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/tsconfig.json
db2b2a3 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/tsconfig.json
de5b14f 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update examples/angular/basic-persister/tsconfig.json
03b9c02 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich @arnoud-dv
Update packages/angular-query-experimental/src/inject-is-restoring.ts
67d3f38 
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
@OmerGronich
fix(angular-query): fixed lock file
b30b21b
@OmerGronich
fix(angular-query): aligned package.json versions
c9ec26a
@OmerGronich
added missing dep from basic-persister example
b858927
@OmerGronich
Added a more complex example for persistence. This examples demonstra…
325b2a7 
…tes how to selectively persist queries to different persisters.
@OmerGronich OmerGronich force-pushed the angular-persist-query-client-experimental branch from ed0ed3c to 325b2a7 Compare December 7, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnoud-dv arnoud-dv Awaiting requested review from arnoud-dv

Assignees

@arnoud-dv arnoud-dv

Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmerGronich @arnoud-dv