Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): ensureSuspenseTimers should ALWAYS set staleTime to 1000 when it is below 1000. #8398

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+203 −60
Open

fix(react-query): ensureSuspenseTimers should ALWAYS set staleTime to 1000 when it is below 1000. #8398

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7c38a96
fix(react-query): ensureSuspenseTimers should ALWAYS set staleTime to…
minseong0324 Dec 4, 2024
2ebd02b
ci: apply automated fixes
autofix-ci[bot] Dec 4, 2024
7a80a02
fix(react-query): fix ensureSuspenseTimers logic
minseong0324 Dec 4, 2024
8bf1909
test(react-query): add test code
minseong0324 Dec 4, 2024
618c6d7
test(react-query): delete unnecessary test code
minseong0324 Dec 4, 2024
bdb0563
Merge branch 'main' into main
minseong0324 Dec 5, 2024
b277d28
Merge branch 'main' into main
TkDodo Dec 11, 2024
46057ca
test(react-query): Refectoring test code to reduce test time
minseong0324 Dec 12, 2024
f06eb49
Merge branch 'main' into main
minseong0324 Dec 15, 2024
33909fb
Merge branch 'main' into main
minseong0324 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/react-query/src/suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@ export const ensureSuspenseTimers = (
defaultedOptions: DefaultedQueryObserverOptions<any, any, any, any, any>,
) => {
if (defaultedOptions.suspense) {
// Always set stale time when using suspense to prevent
// fetching again when directly mounting after suspending
if (defaultedOptions.staleTime === undefined) {
defaultedOptions.staleTime = 1000
}
// Handle staleTime to ensure minimum 1000ms in Suspense mode
// This prevents unnecessary refetching when components remount after suspending
defaultedOptions.staleTime =
typeof defaultedOptions.staleTime === 'function'
? (...args: Parameters<typeof defaultedOptions.staleTime>) =>
Math.max(defaultedOptions.staleTime(...args) ?? 1000, 1000)
: Math.max(defaultedOptions.staleTime ?? 1000, 1000)

if (typeof defaultedOptions.gcTime === 'number') {
defaultedOptions.gcTime = Math.max(defaultedOptions.gcTime, 1000)
}
Expand Down
Loading