Skip to content

refactor(query-core): remove unused common type #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(query-core): remove unused common type #8989

wants to merge 6 commits into from
+0 −5

Conversation

novice0840
Copy link
Contributor

@novice0840 novice0840 commented Apr 10, 2025 •
edited
Loading

I change a type a little.

Optional

I change OmitKeyof to Omit. Since the third parameter TStrictly in OmitKeyof is always fixed, there's no need to use OmitKeyof in this case.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a9ed93c.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 51s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-20 15:59:53 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 10, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8989

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8989

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8989

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8989

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8989

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8989

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8989

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8989

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8989

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8989

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8989

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8989

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8989

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8989

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8989

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8989

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8989

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8989

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8989

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8989

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8989

commit: a9ed93c

@novice0840
fix: revert WithRequired type
Loading
Loading status checks…
a9797f0
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.02%. Comparing base (d040eaa) to head (a9ed93c).
Report is 72 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8989       +/-   ##
===========================================
+ Coverage   44.09%   59.02%   +14.93%     
===========================================
  Files         201      138       -63     
  Lines        8025     5360     -2665     
  Branches     1759     1426      -333     
===========================================
- Hits         3539     3164      -375     
+ Misses       4058     1907     -2151     
+ Partials      428      289      -139
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (-2.86%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 95.95% <ø> (+1.18%) ⬆️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (+15.73%) ⬆️
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@novice0840
fix: remove blank
Loading
Loading status checks…
c40e8c8
@novice0840
refactor(query-core): change Omitkeyof to Omit
Loading
Loading status checks…
01814f7
@TkDodo
Copy link
Collaborator

TkDodo commented Apr 19, 2025

The whole Optional type is unused and can be removed.

@novice0840
refactor: remove unused common type
Loading
Loading status checks…
4de190a
@novice0840
Copy link
Contributor Author

Yes, you are right. type Optional is not used. So I removed it

@novice0840
fix: revert type WithRequired
Loading
Loading status checks…
a9ed93c
@novice0840 novice0840 changed the title refactor(query-core): make common type more readable refactor(query-core): remove unused common type Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@novice0840 @TkDodo