Skip to content

test(query-core/infiniteQueryBehavior): remove most 'vi.waitFor' and add 'advanceTimersByTimeAsync' #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

test(query-core/infiniteQueryBehavior): remove most 'vi.waitFor' and add 'advanceTimersByTimeAsync' #9333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03d2a8b
test(query-core/infiniteQueryBehavior): remove most 'vi.waitFor' and …
sukvvon Jun 29, 2025
1adf1b1
Merge branch 'main' into test/query-core-infiniteQueryBehavior-remove…
manudeli Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 34 additions & 41 deletions packages/query-core/src/__tests__/infiniteQueryBehavior.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ describe('InfiniteQueryBehavior', () => {
observerResult = result
})

await vi.waitFor(() => {
const query = queryCache.find({ queryKey: key })!
return expect(observerResult).toMatchObject({
isError: true,
error: new Error(`Missing queryFn: '${query.queryHash}'`),
})
await vi.advanceTimersByTimeAsync(0)
const query = queryCache.find({ queryKey: key })!
expect(observerResult).toMatchObject({
isError: true,
error: new Error(`Missing queryFn: '${query.queryHash}'`),
})

unsubscribe()
Expand Down Expand Up @@ -75,12 +74,11 @@ describe('InfiniteQueryBehavior', () => {
})

// Wait for the first page to be fetched
await vi.waitFor(() =>
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
}),
)
await vi.advanceTimersByTimeAsync(0)
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
})

expect(queryFnSpy).toHaveBeenNthCalledWith(1, {
queryKey: key,
Expand Down Expand Up @@ -227,14 +225,13 @@ describe('InfiniteQueryBehavior', () => {
query.cancel()

// Wait for the first page to be cancelled
await vi.waitFor(() =>
expect(observerResult).toMatchObject({
isFetching: false,
isError: true,
error: new CancelledError(),
data: undefined,
}),
)
await vi.advanceTimersByTimeAsync(0)
expect(observerResult).toMatchObject({
isFetching: false,
isError: true,
error: new CancelledError(),
data: undefined,
})

expect(queryFnSpy).toHaveBeenCalledTimes(1)

Expand Down Expand Up @@ -276,12 +273,11 @@ describe('InfiniteQueryBehavior', () => {
})

// Wait for the first page to be fetched
await vi.waitFor(() =>
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
}),
)
await vi.advanceTimersByTimeAsync(0)
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
})

queryFnSpy.mockClear()

Expand Down Expand Up @@ -426,12 +422,11 @@ describe('InfiniteQueryBehavior', () => {
observerResult = result
})

await vi.waitFor(() =>
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: ['data'], pageParams: [null] },
}),
)
await vi.advanceTimersByTimeAsync(0)
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: ['data'], pageParams: [null] },
})

unsubscribe()
})
Expand All @@ -454,12 +449,11 @@ describe('InfiniteQueryBehavior', () => {
observerResult = result
})

await vi.waitFor(() =>
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
}),
)
await vi.advanceTimersByTimeAsync(0)
expect(observerResult).toMatchObject({
isFetching: false,
data: { pages: [1], pageParams: [1] },
})

await observer.fetchNextPage()

Expand Down Expand Up @@ -488,9 +482,8 @@ describe('InfiniteQueryBehavior', () => {

const unsubscribe = observer.subscribe(() => {})

await vi.waitFor(() => {
expect(persisterSpy).toHaveBeenCalledTimes(1)
})
await vi.advanceTimersByTimeAsync(0)
expect(persisterSpy).toHaveBeenCalledTimes(1)

unsubscribe()
})
Expand Down
Loading