test(svelte-query/createQueries): simplify 'queryFn' and add test for success when queries reslove at different times #9494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 0e22231
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9494 +/- ##
===========================================
+ Coverage 45.30% 89.20% +43.89%
===========================================
Files 208 18 -190
Lines 8283 176 -8107
Branches 1862 31 -1831
===========================================
- Hits 3753 157 -3596
+ Misses 4085 18 -4067
+ Partials 445 1 -444
🚀 New features to boost your workflow:
|
manudeli
reviewed
Jul 26, 2025
| await vi.advanceTimersByTimeAsync(0) | ||
| expect(rendered.getByText('Status 1: pending')).toBeInTheDocument() | ||
| expect(rendered.getByText('Status 2: pending')).toBeInTheDocument() | ||
|
|
There was a problem hiding this comment.
If queryFn's sleeping time is different, it would be better to add test code for the case after just 10ms, not only this.
Comment on lines
25
to
55
| await sleep(5) | ||
| return 'Success 1' | ||
| }, | ||
| queryFn: () => sleep(10).then(() => 'Success 1'), | ||
| }, | ||
| { | ||
| queryKey: ['key-2'], | ||
| queryFn: async () => { | ||
| await sleep(5) | ||
| return 'Success 2' | ||
| }, | ||
| queryFn: () => sleep(20).then(() => 'Success 2'), |
There was a problem hiding this comment.
If queryFn's sleeping time is different 10ms, 20ms, it would be better to add test code for the case after just 10ms, not only for case after 20ms.
There was a problem hiding this comment.
If queryFn's sleeping time is different 10ms, 20ms, it would be better to add test code for the case after just 10ms, not only for case after 20ms.
That makes sense. I’ll add the test as you suggested.
…time in 'advanceTimersByTimeAsync'
sukvvon
force-pushed
the
test/svelte-query-createQueries-use-precise-time-advanceTimersByTimeAsync-simplify-queryFn
branch
from
eed9a97 to
f2d7746
Compare
…time-advanceTimersByTimeAsync-simplify-queryFn
…eslove at different times
sukvvon
changed the title
sukvvon
commented
Jul 26, 2025
Comment on lines
+44
to
+71
| test('Render and wait for success when queries resolve at different times', async () => { | ||
| const rendered = render(BaseExample, { | ||
| props: { | ||
| options: { | ||
| queries: [ | ||
| { | ||
| queryKey: ['key-1'], | ||
| queryFn: () => sleep(10).then(() => 'Success 1'), | ||
| }, | ||
| { | ||
| queryKey: ['key-2'], | ||
| queryFn: () => sleep(20).then(() => 'Success 2'), | ||
| }, | ||
| ], | ||
| }, | ||
| queryClient: new QueryClient(), | ||
| }, | ||
| }) | ||
|
|
||
| expect(rendered.getByText('Status 1: pending')).toBeInTheDocument() | ||
| expect(rendered.getByText('Status 2: pending')).toBeInTheDocument() | ||
|
|
||
| await vi.advanceTimersByTimeAsync(11) | ||
| expect(rendered.getByText('Status 1: success')).toBeInTheDocument() | ||
| await vi.advanceTimersByTimeAsync(10) | ||
| expect(rendered.getByText('Status 2: success')).toBeInTheDocument() | ||
| }) | ||
|
|
There was a problem hiding this comment.
If queryFn's sleeping time is different 10ms, 20ms, it would be better to add test code for the case after just 10ms, not only for case after 20ms.
I added the test as you suggested.
…time-advanceTimersByTimeAsync-simplify-queryFn
manudeli
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.