Skip to content

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Oct 16, 2025

🎯 Changes

Changesets created from the GitHub UI are not prettier-compliant, so cause an unnecessary automated fix run.

βœ… Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

πŸš€ Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated Prettier configuration to exclude additional files from formatting.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: 28b56ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lachlancollins lachlancollins merged commit 969801c into main Oct 16, 2025
5 checks passed
@lachlancollins lachlancollins deleted the prettier-ignore-changeset branch October 16, 2025 11:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A single-line addition to .prettierignore excludes Markdown files under the .changeset directory from Prettier formatting, preventing the formatter from modifying Changeset metadata files.

Changes

Cohort / File(s) Summary
Prettier Configuration
.prettierignore
Adds ignore pattern for .changeset/**/*.md to prevent Prettier from formatting Markdown files in the Changesets directory

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ci: introduce changesetsΒ #9502: Introduces Changesets integration, which is the direct motivation for excluding .changeset Markdown files from Prettier formatting.

Poem

🐰 A line so small, yet wise and kind,
Prevents the formatter's gentle mind,
From touching .changeset files with careβ€”
Some things are best left as they are there! ✨

✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prettier-ignore-changeset

πŸ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between a7ff29b and 28b56ec.

πŸ“’ Files selected for processing (1)
  • .prettierignore (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Oct 16, 2025

View your CI Pipeline Execution β†— for commit 28b56ec

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... βœ… Succeeded 44s View β†—
nx run-many --target=build --exclude=examples/*... βœ… Succeeded <1s View β†—

☁️ Nx Cloud last updated this comment at 2025-10-16 11:46:04 UTC

@github-actions
Copy link
Contributor

Sizes for commit 28b56ec:

Branch Bundle Size
Main
This PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants