fix(start): remove debug log that causes dehydration errors #2118
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 321e0b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
The debug 'Injected from Server: ' logs are not properly escaped, causing dehydration to fail. These logs have been removed. <ScriptOnce/> debug logs are removed, and the 'tsr-once' class name set on <ScriptOnce/> elements has an extraneous space suffixed to it which has been removed as well.
lithdew
force-pushed
the
remove-debug-logs
branch
from
e7e67bd to
321e0b6
Compare
| ${children}\`)` | ||
| : '' | ||
| }; __TSR__.cleanScripts()</script>`, | ||
| `<script class='tsr-once'>${children}; __TSR__.cleanScripts()</script>`, |
There was a problem hiding this comment.
Do we need to remove the logging for this? Couldn't we just correctly escape the console.log statements instead?
|
Gonna close this. I think it's better to wait for #2104 before amending this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug 'Injected from Server: ' logs are not properly escaped, causing dehydration to fail. These logs have been removed.
<ScriptOnce/>debug logs are removed, and the 'tsr-once' class name set on elements has an extraneous space suffixed to it which has been removed as well.