Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): basepath case sensitivity during path resolution #2640

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Oct 25, 2024

Fixes #2637

Copy link

nx-cloud bot commented Oct 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4c36aab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere changed the title fix(react-router): case sensitivity checking during path resolution on the basepath fix(react-router): basepath case sensitivity during path resolution Oct 25, 2024
@SeanCassiere SeanCassiere marked this pull request as ready for review October 25, 2024 08:15
Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

More templates

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2640

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2640

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2640

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2640

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2640

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2640

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2640

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2640

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2640

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2640

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2640

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2640

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2640

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2640

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2640

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2640

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2640

commit: 4c36aab

@SeanCassiere SeanCassiere merged commit 5d1702f into main Oct 25, 2024
5 checks passed
@SeanCassiere SeanCassiere deleted the fix-2637 branch October 25, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router.basepath is case sensitive
1 participant