Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(start): sync start serialization on the type level #2809

Merged
merged 8 commits into from
Nov 21, 2024
Merged

fix(start): sync start serialization on the type level #2809

merged 8 commits into from
Nov 21, 2024

Conversation

chorobin
Copy link
Contributor

@chorobin chorobin commented Nov 19, 2024 •
edited
Loading

Fixes #2693

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae0914f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 19, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2809

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2809

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2809

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2809

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2809

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2809

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2809

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2809

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2809

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2809

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2809

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2809

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2809

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2809

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2809

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2809

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2809

commit: ae0914f

@chorobin chorobin merged commit 607ac2b into main Nov 21, 2024
5 checks passed
@chorobin chorobin deleted the fix-fn-response-type branch November 21, 2024 18:54
timoconnellaus pushed a commit to timoconnellaus/tanstack-router that referenced this pull request Dec 4, 2024
@chorobin @timoconnellaus
fix(start): sync start serialization on the type level (TanStack#2809)
100ac00 
* fix(start): allow functions in types

* fix(start): implement start serialization on the type level

* fix(start): validate createServerFn to not allow functions

* refactor(start): make transformer types generic

* feat(start): add type checking of validator and context

* chore: fix linting

* chore: remove serializable types
timoconnellaus pushed a commit to timoconnellaus/tanstack-router that referenced this pull request Dec 19, 2024
@chorobin @timoconnellaus
fix(start): sync start serialization on the type level (TanStack#2809)
b596ca1 
* fix(start): allow functions in types

* fix(start): implement start serialization on the type level

* fix(start): validate createServerFn to not allow functions

* refactor(start): make transformer types generic

* feat(start): add type checking of validator and context

* chore: fix linting

* chore: remove serializable types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanCassiere SeanCassiere SeanCassiere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type safety breaks around Dates and other non standard objects when using server functions
2 participants
@chorobin @SeanCassiere