Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-generator): do not import react in scaffolded route #2884

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

schiller-manuel
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Nov 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dab3409. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2884

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2884

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2884

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2884

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2884

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2884

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2884

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2884

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2884

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2884

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2884

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2884

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2884

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2884

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2884

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2884

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2884

commit: dab3409

@schiller-manuel schiller-manuel merged commit ef6f4fe into main Nov 28, 2024
4 of 5 checks passed
@schiller-manuel schiller-manuel deleted the no-react-scaffold branch November 28, 2024 22:44
timoconnellaus pushed a commit to timoconnellaus/tanstack-router that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant