Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): allow union when assigning #2994

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

chorobin
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Dec 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5865461. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 12, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2994

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2994

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2994

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2994

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2994

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2994

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2994

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2994

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2994

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2994

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2994

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2994

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2994

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2994

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2994

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2994

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2994

commit: 5865461

@chorobin chorobin merged commit ec50a80 into main Dec 12, 2024
5 checks passed
@chorobin chorobin deleted the allow-union-search branch December 12, 2024 18:58
@GiovaniGuizzoYUB
Copy link

This PR has broken my application's search params. I have a param A that's optional from the root route and a param B that's also optional from a page. It essentially makes the page's search param types to be something like this:

{ A: {}; } | { B: string; } | { A: {}; B: string; } | undefined

This type is basically unusable and TypeScript throws an error when I try to use search param B:

Property 'B' does not exist on type '{ A: {}; }'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants