Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): use correct type for TRouter generic #2998

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Dec 12, 2024

I think this is a typo.

There are many instances with TRouter extends AnyRouter: https://github.com/search?q=repo%3ATanStack%2Frouter+%22TRouter+extends+AnyRouter%22&type=code

There are a few other instances with TRouter extends RegisteredRouter which should probably be audited: https://github.com/search?q=repo%3ATanStack%2Frouter+%22TRouter+extends+RegisteredRouter%22&type=code.

@schiller-manuel
Copy link
Contributor

I think this is a type performance thing, but let's ask @chorobin

Copy link

nx-cloud bot commented Dec 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c460f64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 14, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2998

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2998

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2998

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2998

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2998

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2998

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2998

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2998

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2998

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2998

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2998

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2998

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2998

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@2998

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2998

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2998

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2998

commit: c460f64

@schiller-manuel schiller-manuel changed the title fix: use correct type for TRouter generic fix(react-router): use correct type for TRouter generic Dec 15, 2024
@schiller-manuel schiller-manuel merged commit 6e4ff67 into TanStack:main Dec 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants