Skip to content

Conversation

@SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Feb 12, 2025

#3363 introduced the option of "targets" in the router-generator. As a follow up to that PR, this change supports the "target" option, when doing automatic code-splitting.

@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit 1ced674.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 34s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 02:17:24 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3400

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3400

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3400

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3400

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3400

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3400

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3400

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3400

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3400

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3400

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3400

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3400

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3400

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3400

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3400

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3400

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3400

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3400

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3400

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3400

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3400

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3400

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3400

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3400

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3400

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3400

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3400

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3400

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3400

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3400

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3400

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3400

commit: 1ced674

@SeanCassiere SeanCassiere marked this pull request as ready for review February 12, 2025 02:18
@SeanCassiere SeanCassiere merged commit e88b960 into main Feb 12, 2025
5 checks passed
@SeanCassiere SeanCassiere changed the title refactor(router-plugin): code-splitting to be agnostic of 'targets' refactor(router-plugin): code-splitting to be agnostic to support 'targets' Feb 12, 2025
@SeanCassiere SeanCassiere deleted the refactor/codesplitting-to-use-targets branch February 12, 2025 02:21
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants