Skip to content

test(react-router) should update title on navigation #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 7 commits into from
Mar 2, 2025
Merged

test(react-router) should update title on navigation #3610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e569e5
test(react-router) should update title on nav
birkskyum Feb 28, 2025
fcc9c16
Merge branch 'main' into test(react-router)-should-update-title-on-na…
birkskyum Feb 28, 2025
fecb4d8
also test solid-router
birkskyum Feb 28, 2025
df467ad
remove solid-router
birkskyum Mar 1, 2025
918774a
remove solid
birkskyum Mar 1, 2025
5bd18df
remove title from index.html
birkskyum Mar 1, 2025
eeb77d4
render HeadContent
schiller-manuel Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion e2e/react-router/basic-file-based/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite App</title>
</head>
<body>
<div id="app"></div>
Expand Down
2 changes: 2 additions & 0 deletions e2e/react-router/basic-file-based/src/routes/__root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
HeadContent,
Link,
Outlet,
createRootRoute,
Expand All @@ -25,6 +26,7 @@ function RootComponent() {

return (
<>
<HeadContent />
<div className="flex gap-2 p-2 text-lg border-b">
<button
data-testid="back-button"
Expand Down
7 changes: 7 additions & 0 deletions e2e/react-router/basic-file-based/src/routes/posts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import { Link, Outlet, createFileRoute } from '@tanstack/react-router'
import { fetchPosts } from '../posts'

export const Route = createFileRoute('/posts')({
head: () => ({
meta: [
{
title: 'Posts page',
},
],
}),
loader: fetchPosts,
component: PostsComponent,
})
Expand Down
8 changes: 8 additions & 0 deletions e2e/react-router/basic-file-based/tests/app.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,11 @@ test('structural sharing enabled', async ({ page }) => {
await page.getByTestId('link').click()
expect(await getRenderCount(page)).toBe(2)
})

test('Should change title on client side navigation', async ({ page }) => {
await page.goto('/')

await page.getByRole('link', { name: 'Posts' }).click()

await expect(page).toHaveTitle('Posts page')
})