fix: ensure compatibility with vite plugins that don't support the vite environment API #4167

schiller-manuel · 2025-05-13T16:57:27Z

some (most?) vite plugins don't support the new vite environment API yet, among those is the tailwind vite plugin.
the fallback that vite uses for those plugins assumes the server environment is called "ssr".
this PR renames start's server environment to "ssr" to ensure compatibility with those plugins.

fixes #4132

nx-cloud · 2025-05-13T16:57:46Z

View your CI Pipeline Execution ↗ for commit 80412f9.

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	3m 27s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	20s	View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 22:48:36 UTC

pkg-pr-new · 2025-05-13T17:01:17Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4167

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4167

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4167

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4167

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4167

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4167

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4167

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4167

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4167

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4167

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4167

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4167

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4167

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4167

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4167

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4167

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4167

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4167

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4167

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4167

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4167

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4167

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4167

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4167

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4167

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4167

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4167

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4167

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4167

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4167

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4167

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4167

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4167

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4167

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4167

commit: 80412f9

instead, depend on environment consumer

this importer is used during dev

github-actions bot added package: router-plugin package: server-functions-plugin package: react-start-plugin package: solid-start-plugin package: start-plugin-core labels May 13, 2025

github-actions bot added package: directive-functions-plugin package: start-server-core labels May 13, 2025

schiller-manuel force-pushed the fix-legacy-vite-plugin-compat branch from 4f4f3f9 to ac0e9df Compare May 13, 2025 21:55

github-actions bot removed the package: directive-functions-plugin label May 13, 2025

schiller-manuel added 13 commits May 14, 2025 00:00

consolidate usage of TanStackServerFnPluginEnv

2db5210

decouple router generator plugin execution from environment name

db1171d

instead, depend on environment consumer

forward env names in TanStackServerFnPluginEnv

a0cfb11

move vite environment names into constants

187cece

fix formatting

7fcc2b5

set environement names when using TanStackServerFnPluginEnv

eba2cbe

add react-start tailwind v4 example

edf88b5

use VITE_ENVIRONMENT_NAMES in devServerPlugin

827fb3b

fix lint

692e36a

fix plugin order

c0b2a8b

allow to specify importer in server-functions-plugin

1cde331

this importer is used during dev

specify dev importer in start-plugin-core

e50f59e

fix lockfile

cc45930

schiller-manuel force-pushed the fix-legacy-vite-plugin-compat branch from 47b34a0 to cc45930 Compare May 13, 2025 22:01

schiller-manuel mentioned this pull request May 13, 2025

v4 vite plugin is not compatible with the vite environment API tailwindlabs/tailwindcss#18002

Open

schiller-manuel force-pushed the fix-legacy-vite-plugin-compat branch 2 times, most recently from 256e163 to 89f3dc7 Compare May 13, 2025 22:37

fix types

ccc0a8e

schiller-manuel force-pushed the fix-legacy-vite-plugin-compat branch from 89f3dc7 to ccc0a8e Compare May 13, 2025 22:40

fix lint

80412f9

schiller-manuel merged commit 1417d17 into alpha May 13, 2025
4 of 5 checks passed

schiller-manuel deleted the fix-legacy-vite-plugin-compat branch May 13, 2025 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: ensure compatibility with vite plugins that don't support the vite environment API #4167

fix: ensure compatibility with vite plugins that don't support the vite environment API #4167

Uh oh!

schiller-manuel commented May 13, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented May 13, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix: ensure compatibility with vite plugins that don't support the vite environment API #4167

fix: ensure compatibility with vite plugins that don't support the vite environment API #4167

Uh oh!

Conversation

schiller-manuel commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

schiller-manuel commented May 13, 2025 •

edited

Loading

nx-cloud bot commented May 13, 2025 •

edited

Loading

pkg-pr-new bot commented May 13, 2025 •

edited

Loading