Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore router.history and usePrompt behavior #461

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

tombuntus
Copy link
Member

  • restores router.history in the public API or router-core
  • restores usePrompt block / unblock behavior

@vercel
Copy link

vercel bot commented Dec 20, 2022

@tombuntus is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@tannerlinsley
Copy link
Collaborator

My bad, it needs a bit more. This line needs to go away and just use the routers property

let history = userOptions?.history || createDefaultHistory()
and also anything referencing that let variable will need to be updated as well.

@tombuntus
Copy link
Member Author

@tannerlinsley I missed that! If I've understood correctly, this should be good now.

@tannerlinsley tannerlinsley merged commit c4ce01b into TanStack:beta Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants