fix(router-core): parse _strictParams - alpha #5121
Merged
+556
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
|
View your CI Pipeline Execution ↗ for commit 6f19b58
☁️ Nx Cloud last updated this comment at |
nlynzaad
changed the title
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
nlynzaad
added a commit
that referenced
this pull request
Sep 11, 2025
with changing useParams to make use of _strictParams it became apparent that _strictParams did not apply param parsing correctly. This PR resolves that problem and hence useParams now return the parsed params correctly. This PR also adds unit tests in both react-router and solid-router to test this expected result. A separate PR has been created to merge into alpha (#5121) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Stricter route parameter parsing and validation with support for custom parse/stringify. - Clearer per-route parameter error reporting, with optional throw-on-error behavior. - More consistent parameter values across nested routes and loaders. - Tests - Added integration tests validating useParams with nested routing, custom param parsing/stringifying, and loader data in both React and Solid routers. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
LadyBluenotes
pushed a commit
to LadyBluenotes/router
that referenced
this pull request
Sep 19, 2025
with changing useParams to make use of _strictParams it became apparent that _strictParams did not apply param parsing correctly. This PR resolves that problem and hence useParams now return the parsed params correctly. This PR also adds unit tests in both react-router and solid-router to test this expected result. A separate PR has been created to merge into alpha (TanStack#5121) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Stricter route parameter parsing and validation with support for custom parse/stringify. - Clearer per-route parameter error reporting, with optional throw-on-error behavior. - More consistent parameter values across nested routes and loaders. - Tests - Added integration tests validating useParams with nested routing, custom param parsing/stringifying, and loader data in both React and Solid routers. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge #5210 into alpha once accepted