Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions e2e/react-router/basic-file-based/src/routeTree.gen.ts

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { createFileRoute } from '@tanstack/react-router'

export const Route = createFileRoute('/non-nested/baz/$bazid')({
component: RouteComponent,
})

function RouteComponent() {
const params = Route.useParams()

return (
<>
<div data-testid="non-nested-bazid-heading">
Hello "/non-nested/baz/$bazid"!
</div>
<div>
params:{' '}
<span data-testid="non-nested-bazid-param">
{JSON.stringify(params)}
</span>
</div>
</>
)
}
14 changes: 14 additions & 0 deletions e2e/react-router/basic-file-based/src/routes/non-nested/baz.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { Outlet, createFileRoute } from '@tanstack/react-router'

export const Route = createFileRoute('/non-nested/baz')({
component: RouteComponent,
})

function RouteComponent() {
return (
<>
<div data-testid="non-nested-baz-heading">Hello "/non-nested/baz"!</div>
<Outlet />
</>
)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { createFileRoute } from '@tanstack/react-router'

export const Route = createFileRoute('/non-nested/baz_/$bazid/edit')({
component: RouteComponent,
})

function RouteComponent() {
const params = Route.useParams()
return (
<>
<div data-testid="non-nested-bazid-edit-heading">
Hello "/non-nested/baz_/$bazid/edit"!
</div>
<div>
params:{' '}
<span data-testid="non-nested-bazid-edit-param">
{JSON.stringify(params)}
</span>
</div>
</>
)
}
38 changes: 38 additions & 0 deletions e2e/react-router/basic-file-based/src/routes/non-nested/route.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { Link, Outlet, createFileRoute } from '@tanstack/react-router'

export const Route = createFileRoute('/non-nested')({
component: RouteComponent,
})

function RouteComponent() {
return (
<div>
<h3 className="pb-2" data-testid="non-nested-path-heading">
Non-nested paths
</h3>
<ul className="grid mb-2">
<li>
<Link
from={Route.fullPath}
data-testid="l-to-non-nested-bazid"
to="./baz/$bazid"
params={{ bazid: '123' }}
>
/non-nested/baz/123
</Link>
</li>
<li>
<Link
from={Route.fullPath}
data-testid="l-to-non-nested-bazid-edit"
to="./baz/$bazid/edit"
params={{ bazid: '456' }}
>
/non-nested/baz/456/edit
</Link>
</li>
</ul>
<Outlet />
</div>
)
}
35 changes: 35 additions & 0 deletions e2e/react-router/basic-file-based/tests/app.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,3 +308,38 @@ test('Should remount deps when remountDeps does change ', async ({ page }) => {
'Page component mounts: 2',
)
})

test('Should not nest non-nested paths', async ({ page }) => {
await page.goto('/non-nested')
await page.waitForURL('/non-nested')
const nonNestedPathHeading = page.getByTestId('non-nested-path-heading')
const bazIdLink = page.getByTestId('l-to-non-nested-bazid')
const bazIdEditLink = page.getByTestId('l-to-non-nested-bazid-edit')

await expect(nonNestedPathHeading).toBeInViewport()
await expect(bazIdLink).toHaveAttribute('href', '/non-nested/baz/123')
await expect(bazIdEditLink).toHaveAttribute(
'href',
'/non-nested/baz/456/edit',
)

await bazIdLink.click()
await page.waitForURL('/non-nested/baz/123')
const bazHeading = page.getByTestId('non-nested-baz-heading')
const bazIdHeading = page.getByTestId('non-nested-bazid-heading')
const bazIdParam = page.getByTestId('non-nested-bazid-param')
await expect(nonNestedPathHeading).toBeInViewport()
await expect(bazHeading).toBeInViewport()
await expect(bazIdHeading).toBeInViewport()
await expect(bazIdParam).toContainText(JSON.stringify({ bazid: '123' }))

await bazIdEditLink.click()
await page.waitForURL('/non-nested/baz/456/edit')
const bazIdEditHeading = page.getByTestId('non-nested-bazid-edit-heading')
const bazIdEditParam = page.getByTestId('non-nested-bazid-edit-param')
await expect(nonNestedPathHeading).toBeInViewport()
await expect(bazHeading).toBeHidden()
await expect(bazIdHeading).toBeHidden()
await expect(bazIdEditHeading).toBeInViewport()
await expect(bazIdEditParam).toContainText(JSON.stringify({ bazid: '456' }))
})
Loading
Loading