-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
examples: fix paraglide start example #5344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConverted the route loader to async and removed localeFromLoader from returned data and component usage. The loader now awaits getServerMessage. Adjusted heading level from h3 to h2. Updated Vite i18n config to add root '/' localization mapping for en and de alongside existing patterns. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as User (Browser)
participant Router as React Router
participant Loader as Route Loader (async)
participant SrvFn as getServerMessage (server)
participant UI as Home Component
User->>Router: Navigate to index route
Router->>Loader: Invoke loader()
activate Loader
Loader->>SrvFn: await getServerMessage({ data: "📩" })
activate SrvFn
SrvFn-->>Loader: serverFunctionMessage
deactivate SrvFn
Loader-->>Router: { serverFunctionMessage, messageFromLoader }
deactivate Loader
Router->>UI: Provide loader data
UI-->>User: Render with <h2> and messages
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit e5bd682
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Summary by CodeRabbit
New Features
Refactor
Style