-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: Update Some Router Docs #5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReorganizes documentation: creates a new top-level "Installation Guides" grouping framework-specific installation flows, moves/renames installation pages, removes obsolete React comparison and installation pages, adds a React manual setup guide and expanded FAQ, updates quick-starts for React and Solid, and fixes cross-links in READMEs and routing docs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit bd18cde
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
docs/router/config.json(1 hunks)docs/router/framework/react/comparison.md(0 hunks)docs/router/framework/react/faq.md(1 hunks)docs/router/framework/react/installation.md(0 hunks)docs/router/framework/react/installation/manual.md(1 hunks)docs/router/framework/react/quick-start.md(1 hunks)docs/router/framework/react/routing/file-based-routing.md(1 hunks)docs/router/framework/solid/installation/manual.md(1 hunks)docs/router/framework/solid/quick-start.md(1 hunks)docs/router/framework/solid/routing/installation-with-router-cli.md(1 hunks)docs/router/framework/solid/routing/installation-with-vite.md(1 hunks)packages/router-cli/README.md(1 hunks)packages/router-plugin/README.md(1 hunks)
💤 Files with no reviewable changes (2)
- docs/router/framework/react/comparison.md
- docs/router/framework/react/installation.md
🧰 Additional context used
📓 Path-based instructions (4)
packages/{router-cli,router-generator,router-plugin,virtual-file-routes}/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep CLI, generators, bundler plugins, and virtual file routing utilities in their dedicated tooling package directories
Files:
packages/router-cli/README.mdpackages/router-plugin/README.md
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (AGENTS.md)
Use internal docs links relative to the docs/ folder (e.g., ./guide/data-loading)
Files:
docs/router/framework/react/routing/file-based-routing.mddocs/router/framework/react/installation/manual.mddocs/router/framework/react/quick-start.mddocs/router/framework/solid/routing/installation-with-router-cli.mddocs/router/framework/solid/routing/installation-with-vite.mddocs/router/framework/react/faq.mddocs/router/framework/solid/installation/manual.mddocs/router/framework/solid/quick-start.md
docs/{router,start}/**
📄 CodeRabbit inference engine (AGENTS.md)
Place router docs under docs/router/ and start framework docs under docs/start/
Files:
docs/router/framework/react/routing/file-based-routing.mddocs/router/framework/react/installation/manual.mddocs/router/framework/react/quick-start.mddocs/router/framework/solid/routing/installation-with-router-cli.mddocs/router/framework/solid/routing/installation-with-vite.mddocs/router/config.jsondocs/router/framework/react/faq.mddocs/router/framework/solid/installation/manual.mddocs/router/framework/solid/quick-start.md
packages/router-plugin/**
📄 CodeRabbit inference engine (AGENTS.md)
Use unplugin for universal bundler plugins in the router-plugin package
Files:
packages/router-plugin/README.md
🧠 Learnings (1)
📚 Learning: 2025-10-01T18:31:35.420Z
Learnt from: schiller-manuel
PR: TanStack/router#5330
File: e2e/react-start/custom-basepath/src/routeTree.gen.ts:58-61
Timestamp: 2025-10-01T18:31:35.420Z
Learning: Do not review files named `routeTree.gen.ts` in TanStack Router repositories, as these are autogenerated files that should not be manually modified.
Applied to files:
docs/router/framework/react/faq.md
🪛 markdownlint-cli2 (0.18.1)
packages/router-cli/README.md
5-5: Bare URL used
(MD034, no-bare-urls)
docs/router/framework/react/installation/manual.md
9-9: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
packages/router-plugin/README.md
13-13: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit