Skip to content

Conversation

@pi0
Copy link
Contributor

@pi0 pi0 commented Nov 11, 2025

Simplify docs to recommand latest nitro v3 native vite plugin as we can support it easier.

/cc @schiller-manuel

Summary by CodeRabbit

  • Documentation
    • Consolidated React hosting guide around Nitro v3 deployment and "hostings" usage
    • Removed legacy Nitro v2/ALPHA guidance and outdated references
    • Updated examples to use the Nitro v3 Vite plugin and a unified configuration pattern (including Bun presets)
    • Clarified import order, comments, and links to reflect current Nitro v3 hosting endpoints

@github-actions github-actions bot added the documentation Everything documentation related label Nov 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Warning

Rate limit exceeded

@pi0 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d559af6 and 033cd33.

📒 Files selected for processing (1)
  • docs/start/framework/react/guide/hosting.md (2 hunks)

Walkthrough

Unified React hosting documentation to use Nitro v3: replaced mixed v2/v3 and alpha guidance with Nitro v3 Vite plugin imports (nitro/vite), simplified plugin examples (tanstackStart, nitro, viteReact), and updated hostings/preset references and code samples.

Changes

Cohort / File(s) Change Summary
React Hosting Documentation Update
docs/start/framework/react/guide/hosting.md
Replaced legacy Nitro v2/v3 ALPHA guidance with unified Nitro v3 usage; updated plugin import to nitro/vite; simplified plugin arrays to tanstackStart(), nitro(), viteReact() and added nitro({ preset: 'bun' }) examples; updated textual references to "hostings" and Nitro v3 links.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Docs-only, consistent pattern changes across one file
  • Pay attention to:
    • Correctness of nitro/vite import paths and plugin names
    • Consistency of example plugin ordering and nitro({ preset: 'bun' }) usage
    • Updated links pointing to Nitro v3 documentation

Possibly related PRs

Poem

🐰
Nitro hopped to version three, so bright,
I rewrote guides by lantern-light.
Plugins tidy, imports neat,
Hosting docs now dance on two soft feet.
Hop on—deploy and take flight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'docs(hosting): update nitro to v3' clearly and concisely summarizes the main change: updating documentation for Nitro hosting to version 3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
docs/start/framework/react/guide/hosting.md (2)

194-210: Nitro v3 documentation updates look good overall; minor text refinement suggested.

The transition to Nitro v3 references, import from nitro/vite, and simplified plugin configuration are all correct. However, line 198's phrasing is slightly awkward: "Please report any issues that you encounter to investigate" could be improved to "Please report any issues that you encounter" (the investigative action is implied).

Apply this diff for clearer phrasing:

-**The [`nitro/vite`](https://v3.nitro.build/) plugin is an official plugin from the Nitro team for using Nitro v3 as the underlying build tool for TanStack Start. It is still in development and is receiving regular updates. Please report any issues that you encounter to investigate.**
+**The [`nitro/vite`](https://v3.nitro.build/) plugin is an official plugin from the Nitro team for using Nitro v3 as the underlying build tool for TanStack Start. It is still in development and is receiving regular updates. Please report any issues that you encounter.**

398-401: Update Appwrite output directory comment for Nitro v3 consolidation.

Since this PR consolidates documentation to Nitro v3 only, the comment on line 400 mentioning both "v2 or v3" is slightly inconsistent. Consider updating for clarity.

Apply this diff for consistency with the v3-focused documentation:

   - **Output directory:** `./dist` (if you're using Nitro v2 or v3, this should be `./.output`)
+  - **Output directory:** `./dist` (if you're using Nitro v3, this should be `./.output`)
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5404201 and 708beef.

📒 Files selected for processing (1)
  • docs/start/framework/react/guide/hosting.md (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (AGENTS.md)

Use internal docs links relative to the docs/ folder (e.g., ./guide/data-loading)

Files:

  • docs/start/framework/react/guide/hosting.md
docs/{router,start}/**

📄 CodeRabbit inference engine (AGENTS.md)

Place router docs under docs/router/ and start framework docs under docs/start/

Files:

  • docs/start/framework/react/guide/hosting.md

@nx-cloud
Copy link

nx-cloud bot commented Nov 11, 2025

View your CI Pipeline Execution ↗ for commit 033cd33

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 21:13:41 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 11, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5821

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5821

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5821

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5821

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5821

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5821

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5821

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5821

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5821

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5821

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5821

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5821

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5821

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5821

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5821

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5821

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5821

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5821

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5821

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5821

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5821

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5821

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5821

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5821

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5821

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5821

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5821

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5821

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5821

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5821

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5821

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5821

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5821

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5821

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5821

commit: 033cd33

@schiller-manuel schiller-manuel merged commit 33c3d40 into TanStack:main Nov 11, 2025
6 checks passed
roduyemi pushed a commit to roduyemi/oss-router that referenced this pull request Nov 19, 2025
@TheOrdinaryWow
Copy link

this seems outdated. server.ts no longer works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants