fix: full npm registry URLs, sync package versions#6035
Conversation
github-actions
bot
added
package: react-router
package: router-core
package: router-plugin
package: router-generator
package: directive-functions-plugin
package: router-utils
package: router-cli
package: history
package: eslint-plugin-router
package: server-functions-plugin
package: valibot-adapter
package: router-devtools
package: zod-adapter
package: solid-router
package: arktype-adapter
package: router-vite-plugin
package: react-start-server
package: react-start
package: react-start-client
package: solid-start-client
package: solid-start-server
package: router-devtools-core
package: react-router-devtools
package: solid-start
package: solid-router-devtools
package: start-plugin-core
package: start-server-core
package: start-client-core
labels
github-actions
bot
added
package: virtual-file-routes
package: start-static-server-functions
package: start-storage-context
package: react-router-ssr-query
package: router-ssr-query-core
package: nitro-v2-vite-plugin
package: solid-router-ssr-query
package: vue-router
package: vue-router-devtools
package: vue-router-ssr-query
labels
WalkthroughMassive manifest-only update: many package.json files had dependency version bumps (primarily tailwindcss ^4.1.15 → ^4.1.17), numerous repository.url fields switched to git+https, pnpm bumped, a few tsconfig.json and generated route changes, and a new/updated e2e package.json for React Start RSC. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–20 minutes Files needing extra attention:
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 83abc65
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (9)
examples/solid/start-basic-auth/package.json (1)
13-23: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@libsql/client": "^0.15.15", "@prisma/adapter-libsql": "^7.0.0", "@prisma/client": "^7.0.0", - "@tanstack/solid-router": "^1.139.14", - "@tanstack/solid-router-devtools": "^1.139.15", - "@tanstack/solid-start": "^1.139.14", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", + "@tanstack/solid-start": "workspace:*", "redaxios": "^0.5.1", "solid-js": "^1.9.10", "tailwind-merge": "^2.6.0" }examples/solid/basic/package.json (1)
11-19: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/solid-router": "^1.139.14", - "@tanstack/solid-router-devtools": "^1.139.15", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", "postcss": "^8.5.1", "redaxios": "^0.5.1", "solid-js": "^1.9.10", "tailwindcss": "^4.1.17" }examples/react/quickstart-file-based/package.json (1)
11-22: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/react-router": "^1.139.14", - "@tanstack/react-router-devtools": "^1.139.15", - "@tanstack/router-plugin": "^1.139.14", + "@tanstack/react-router": "workspace:*", + "@tanstack/react-router-devtools": "workspace:*", + "@tanstack/router-plugin": "workspace:*", "postcss": "^8.5.1", "react": "^19.0.0", "react-dom": "^19.0.0", "redaxios": "^0.5.1", "tailwindcss": "^4.1.17", "zod": "^3.24.2" }examples/react/with-trpc-react-query/package.json (1)
12-29: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/react-query": "^5.90.0", - "@tanstack/react-query-devtools": "^5.90.0", - "@tanstack/react-router": "^1.139.14", - "@tanstack/react-router-devtools": "^1.139.15", - "@tanstack/router-plugin": "^1.139.14", + "@tanstack/react-query": "workspace:*", + "@tanstack/react-query-devtools": "workspace:*", + "@tanstack/react-router": "workspace:*", + "@tanstack/react-router-devtools": "workspace:*", + "@tanstack/router-plugin": "workspace:*", "@trpc/client": "^11.4.3", "@trpc/server": "^11.4.3", "@trpc/tanstack-react-query": "^11.4.3", "express": "^4.21.2", "postcss": "^8.5.1", "react": "^19.1.0", "react-dom": "^19.1.0", "redaxios": "^0.5.1", "tailwindcss": "^4.1.17", "zod": "^3.24.2" }examples/react/view-transitions/package.json (1)
11-22: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/react-router": "^1.139.14", - "@tanstack/react-router-devtools": "^1.139.15", - "@tanstack/router-plugin": "^1.139.14", + "@tanstack/react-router": "workspace:*", + "@tanstack/react-router-devtools": "workspace:*", + "@tanstack/router-plugin": "workspace:*", "postcss": "^8.5.1", "react": "^19.0.0", "react-dom": "^19.0.0", "redaxios": "^0.5.1", "tailwindcss": "^4.1.17", "zod": "^3.24.2" }examples/solid/kitchen-sink/package.json (1)
11-21: Use workspace protocol for internal dependencies.Internal @TanStack packages should use the
workspace:*protocol instead of explicit version specifiers, as per coding guidelines.Apply this diff to align with the workspace protocol:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/solid-router": "^1.139.14", - "@tanstack/solid-router-devtools": "^1.139.15", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", "immer": "^10.1.1", "postcss": "^8.5.1", "solid-js": "^1.9.10", "redaxios": "^0.5.1", "tailwindcss": "^4.1.17", "zod": "^3.24.2" }e2e/vue-router/basic/package.json (1)
15-16: Useworkspace:*for internal dependencies per coding guidelines.Internal TanStack dependencies should use the
workspace:*protocol instead ofworkspace:^to ensure consistent dependency management across the monorepo. As per coding guidelines, workspace protocol should beworkspace:*.Apply this diff to align with coding guidelines:
"dependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/vue-router": "workspace:^", - "@tanstack/vue-router-devtools": "workspace:^", + "@tanstack/vue-router": "workspace:*", + "@tanstack/vue-router-devtools": "workspace:*", "postcss": "^8.5.1", "redaxios": "^0.5.1","devDependencies": { - "@tanstack/router-e2e-utils": "workspace:^", + "@tanstack/router-e2e-utils": "workspace:*", "@playwright/test": "^1.50.1",Also applies to: 24-24
e2e/solid-start/spa-mode/package.json (1)
15-17: Useworkspace:*for internal dependencies per coding guidelines.Internal TanStack dependencies should use the
workspace:*protocol instead ofworkspace:^to ensure consistent dependency management across the monorepo. As per coding guidelines, workspace protocol should beworkspace:*.Apply this diff to align with coding guidelines:
"dependencies": { - "@tanstack/solid-router": "workspace:^", - "@tanstack/solid-router-devtools": "workspace:^", - "@tanstack/solid-start": "workspace:^", + "@tanstack/solid-router": "workspace:*", + "@tanstack/solid-router-devtools": "workspace:*", + "@tanstack/solid-start": "workspace:*", "solid-js": "^1.9.10","devDependencies": { "@tailwindcss/postcss": "^4.1.15", - "@tanstack/router-e2e-utils": "workspace:^", + "@tanstack/router-e2e-utils": "workspace:*", "postcss": "^8.5.1",Also applies to: 23-23
examples/react/quickstart-rspack-file-based/package.json (1)
12-13: Use workspace protocol for internal dependencies.Lines 12-13 reference internal
@tanstackpackages with version numbers instead of theworkspace:*protocol. Per coding guidelines, internal dependencies should useworkspace:*.Apply this diff to align with workspace protocol guidelines:
"dependencies": { - "@tanstack/react-router": "^1.139.14", - "@tanstack/react-router-devtools": "^1.139.15", + "@tanstack/react-router": "workspace:*", + "@tanstack/react-router-devtools": "workspace:*",
🧹 Nitpick comments (1)
e2e/react-start/server-routes/package.json (1)
40-40: Align internal dependencies to workspace: protocol per coding guidelines.*The file uses
workspace:^for internal TanStack dependencies (lines 16-19, 31), but the repo standard and coding guidelines specifyworkspace:*. Update all five internal dependencies to use theworkspace:*protocol.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (201)
e2e/react-router/basic-file-based-code-splitting/package.json(1 hunks)e2e/react-router/basic-file-based/package.json(1 hunks)e2e/react-router/basic-react-query-file-based/package.json(1 hunks)e2e/react-router/basic-react-query/package.json(1 hunks)e2e/react-router/basic-scroll-restoration/package.json(1 hunks)e2e/react-router/basic-virtual-file-based/package.json(1 hunks)e2e/react-router/basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/react-router/basic/package.json(1 hunks)e2e/react-router/generator-cli-only/package.json(1 hunks)e2e/react-router/js-only-file-based/package.json(1 hunks)e2e/react-router/rspack-basic-file-based/package.json(1 hunks)e2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/react-router/scroll-restoration-sandbox-vite/package.json(1 hunks)e2e/react-router/sentry-integration/package.json(1 hunks)e2e/react-router/view-transitions/package.json(1 hunks)e2e/react-start/basic-auth/package.json(1 hunks)e2e/react-start/basic-cloudflare/package.json(1 hunks)e2e/react-start/basic-react-query/package.json(1 hunks)e2e/react-start/basic-rsc/package.disabled.json(0 hunks)e2e/react-start/basic-rsc/package.json(1 hunks)e2e/react-start/basic/package.json(1 hunks)e2e/react-start/custom-basepath/package.json(1 hunks)e2e/react-start/query-integration/package.json(1 hunks)e2e/react-start/scroll-restoration/package.json(1 hunks)e2e/react-start/selective-ssr/package.json(1 hunks)e2e/react-start/serialization-adapters/package.json(1 hunks)e2e/react-start/server-functions/package.json(1 hunks)e2e/react-start/server-routes/package.json(1 hunks)e2e/react-start/spa-mode/package.json(1 hunks)e2e/react-start/virtual-routes/package.json(1 hunks)e2e/react-start/website/package.json(1 hunks)e2e/solid-router/basic-file-based-code-splitting/package.json(1 hunks)e2e/solid-router/basic-file-based/package.json(1 hunks)e2e/solid-router/basic-scroll-restoration/package.json(1 hunks)e2e/solid-router/basic-solid-query-file-based/package.json(1 hunks)e2e/solid-router/basic-solid-query/package.json(1 hunks)e2e/solid-router/basic-virtual-file-based/package.json(1 hunks)e2e/solid-router/basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/solid-router/basic/package.json(1 hunks)e2e/solid-router/generator-cli-only/package.json(1 hunks)e2e/solid-router/js-only-file-based/package.json(1 hunks)e2e/solid-router/rspack-basic-file-based/package.json(1 hunks)e2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.json(1 hunks)e2e/solid-router/scroll-restoration-sandbox-vite/package.json(1 hunks)e2e/solid-router/sentry-integration/package.json(1 hunks)e2e/solid-router/view-transitions/package.json(1 hunks)e2e/solid-start/basic-auth/package.json(1 hunks)e2e/solid-start/basic-cloudflare/package.json(1 hunks)e2e/solid-start/basic-solid-query/package.json(1 hunks)e2e/solid-start/basic/package.json(1 hunks)e2e/solid-start/custom-basepath/package.json(1 hunks)e2e/solid-start/query-integration/package.json(1 hunks)e2e/solid-start/scroll-restoration/package.json(1 hunks)e2e/solid-start/selective-ssr/package.json(1 hunks)e2e/solid-start/serialization-adapters/package.json(1 hunks)e2e/solid-start/server-functions/package.json(1 hunks)e2e/solid-start/server-routes/package.json(1 hunks)e2e/solid-start/spa-mode/package.json(1 hunks)e2e/solid-start/virtual-routes/package.json(1 hunks)e2e/solid-start/website/package.json(1 hunks)e2e/vue-router/basic-file-based-jsx/package.json(1 hunks)e2e/vue-router/basic-file-based-sfc/package.json(2 hunks)e2e/vue-router/basic/package.json(2 hunks)examples/react/authenticated-routes-firebase/package.json(1 hunks)examples/react/authenticated-routes-firebase/tsconfig.json(1 hunks)examples/react/authenticated-routes/package.json(1 hunks)examples/react/authenticated-routes/tsconfig.json(1 hunks)examples/react/basic-default-search-params/package.json(1 hunks)examples/react/basic-devtools-panel/package.json(1 hunks)examples/react/basic-file-based/package.json(1 hunks)examples/react/basic-non-nested-devtools/package.json(1 hunks)examples/react/basic-react-query-file-based/package.json(1 hunks)examples/react/basic-react-query/package.json(1 hunks)examples/react/basic-ssr-streaming-file-based/package.json(2 hunks)examples/react/basic-virtual-file-based/package.json(1 hunks)examples/react/basic-virtual-inside-file-based/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/deferred-data/package.json(1 hunks)examples/react/i18n-paraglide/package.json(1 hunks)examples/react/kitchen-sink-file-based/package.json(1 hunks)examples/react/kitchen-sink-react-query-file-based/package.json(1 hunks)examples/react/kitchen-sink-react-query/package.json(1 hunks)examples/react/kitchen-sink/package.json(1 hunks)examples/react/large-file-based/package.json(1 hunks)examples/react/location-masking/package.json(1 hunks)examples/react/navigation-blocking/package.json(1 hunks)examples/react/quickstart-file-based/package.json(1 hunks)examples/react/quickstart-rspack-file-based/package.json(1 hunks)examples/react/quickstart/package.json(1 hunks)examples/react/scroll-restoration/package.json(1 hunks)examples/react/search-validator-adapters/package.json(1 hunks)examples/react/start-basic-auth/package.json(1 hunks)examples/react/start-basic-authjs/package.json(1 hunks)examples/react/start-basic-cloudflare/package.json(1 hunks)examples/react/start-basic-react-query/package.json(1 hunks)examples/react/start-basic-static/package.json(1 hunks)examples/react/start-basic/package.json(1 hunks)examples/react/start-bun/package.json(1 hunks)examples/react/start-clerk-basic/package.json(1 hunks)examples/react/start-clerk-basic/src/routeTree.gen.ts(1 hunks)examples/react/start-convex-trellaux/package.json(1 hunks)examples/react/start-i18n-paraglide/package.json(1 hunks)examples/react/start-large/package.json(1 hunks)examples/react/start-supabase-basic/package.json(1 hunks)examples/react/start-tailwind-v4/package.json(1 hunks)examples/react/start-trellaux/package.json(1 hunks)examples/react/view-transitions/package.json(1 hunks)examples/react/with-framer-motion/package.json(1 hunks)examples/react/with-trpc-react-query/package.json(1 hunks)examples/react/with-trpc/package.json(1 hunks)examples/solid/authenticated-routes-firebase/package.json(1 hunks)examples/solid/authenticated-routes/package.json(1 hunks)examples/solid/basic-default-search-params/package.json(1 hunks)examples/solid/basic-devtools-panel/package.json(1 hunks)examples/solid/basic-file-based/package.json(1 hunks)examples/solid/basic-non-nested-devtools/package.json(1 hunks)examples/solid/basic-solid-query-file-based/package.json(1 hunks)examples/solid/basic-solid-query/package.json(1 hunks)examples/solid/basic-ssr-streaming-file-based/package.json(1 hunks)examples/solid/basic-virtual-file-based/package.json(1 hunks)examples/solid/basic-virtual-inside-file-based/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/deferred-data/package.json(1 hunks)examples/solid/i18n-paraglide/package.json(1 hunks)examples/solid/kitchen-sink-file-based/package.json(1 hunks)examples/solid/kitchen-sink-solid-query-file-based/package.json(1 hunks)examples/solid/kitchen-sink-solid-query/package.json(1 hunks)examples/solid/kitchen-sink/package.json(1 hunks)examples/solid/large-file-based/package.json(1 hunks)examples/solid/location-masking/package.json(1 hunks)examples/solid/navigation-blocking/package.json(1 hunks)examples/solid/quickstart-file-based/package.json(1 hunks)examples/solid/quickstart-rspack-file-based/package.json(1 hunks)examples/solid/quickstart/package.json(1 hunks)examples/solid/router-monorepo-simple-lazy/packages/post-feature/package.json(1 hunks)examples/solid/router-monorepo-solid-query/package.json(1 hunks)examples/solid/router-monorepo-solid-query/packages/app/package.json(1 hunks)examples/solid/router-monorepo-solid-query/packages/post-feature/package.json(1 hunks)examples/solid/router-monorepo-solid-query/packages/post-query/package.json(1 hunks)examples/solid/router-monorepo-solid-query/packages/router/package.json(1 hunks)examples/solid/scroll-restoration/package.json(1 hunks)examples/solid/search-validator-adapters/package.json(2 hunks)examples/solid/start-basic-auth/package.json(1 hunks)examples/solid/start-basic-authjs/package.json(1 hunks)examples/solid/start-basic-cloudflare/package.json(1 hunks)examples/solid/start-basic-netlify/package.json(1 hunks)examples/solid/start-basic-nitro/package.json(1 hunks)examples/solid/start-basic-solid-query/package.json(1 hunks)examples/solid/start-basic-static/package.json(1 hunks)examples/solid/start-basic/package.json(1 hunks)examples/solid/start-bun/package.json(1 hunks)examples/solid/start-i18n-paraglide/package.json(1 hunks)examples/solid/start-large/package.json(2 hunks)examples/solid/start-supabase-basic/package.json(1 hunks)examples/solid/start-tailwind-v4/package.json(1 hunks)examples/solid/view-transitions/package.json(1 hunks)examples/solid/with-framer-motion/package.json(1 hunks)examples/solid/with-trpc/package.json(1 hunks)examples/vue/basic-file-based-jsx/package.json(1 hunks)examples/vue/basic-file-based-sfc/package.json(2 hunks)examples/vue/basic/package.json(1 hunks)nx.json(1 hunks)package.json(1 hunks)packages/arktype-adapter/package.json(1 hunks)packages/directive-functions-plugin/package.json(1 hunks)packages/eslint-plugin-router/package.json(1 hunks)packages/history/package.json(1 hunks)packages/nitro-v2-vite-plugin/package.json(1 hunks)packages/react-router-devtools/package.json(1 hunks)packages/react-router-ssr-query/package.json(1 hunks)packages/react-router/package.json(1 hunks)packages/react-start-client/package.json(1 hunks)packages/react-start-server/package.json(1 hunks)packages/react-start/package.json(1 hunks)packages/router-cli/package.json(1 hunks)packages/router-core/package.json(1 hunks)packages/router-devtools-core/package.json(1 hunks)packages/router-devtools/package.json(1 hunks)packages/router-generator/package.json(1 hunks)packages/router-plugin/package.json(1 hunks)packages/router-ssr-query-core/package.json(1 hunks)packages/router-utils/package.json(1 hunks)packages/router-vite-plugin/package.json(1 hunks)packages/server-functions-plugin/package.json(1 hunks)packages/solid-router-devtools/package.json(1 hunks)packages/solid-router-ssr-query/package.json(1 hunks)packages/solid-router/package.json(1 hunks)packages/solid-start-client/package.json(1 hunks)packages/solid-start-server/package.json(1 hunks)packages/solid-start/package.json(1 hunks)packages/start-client-core/package.json(1 hunks)packages/start-plugin-core/package.json(1 hunks)packages/start-server-core/package.json(1 hunks)packages/start-static-server-functions/package.json(1 hunks)packages/start-storage-context/package.json(1 hunks)packages/valibot-adapter/package.json(1 hunks)packages/virtual-file-routes/package.json(1 hunks)packages/vue-router-devtools/package.json(1 hunks)packages/vue-router-ssr-query/package.json(1 hunks)packages/vue-router/package.json(1 hunks)packages/zod-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- e2e/react-start/basic-rsc/package.disabled.json
🧰 Additional context used
📓 Path-based instructions (3)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace protocol
workspace:*for internal dependencies in package.json files
Files:
examples/solid/kitchen-sink-file-based/package.jsone2e/solid-start/query-integration/package.jsonexamples/solid/basic-non-nested-devtools/package.jsonpackages/start-static-server-functions/package.jsone2e/react-router/basic-file-based/package.jsone2e/react-start/query-integration/package.jsone2e/react-router/basic/package.jsonexamples/solid/location-masking/package.jsonexamples/react/start-basic-static/package.jsonexamples/solid/start-basic-netlify/package.jsone2e/solid-start/basic-auth/package.jsone2e/solid-start/serialization-adapters/package.jsonexamples/react/basic-virtual-file-based/package.jsone2e/react-start/basic-cloudflare/package.jsonexamples/react/basic-react-query-file-based/package.jsonpackages/solid-router-devtools/package.jsone2e/solid-start/server-routes/package.jsonexamples/react/i18n-paraglide/package.jsonexamples/solid/start-basic/package.jsone2e/react-router/rspack-basic-file-based/package.jsonexamples/solid/basic-virtual-inside-file-based/package.jsonexamples/vue/basic-file-based-sfc/package.jsonpackages/solid-router-ssr-query/package.jsone2e/solid-start/server-functions/package.jsone2e/react-start/basic-react-query/package.jsonexamples/react/navigation-blocking/package.jsone2e/solid-start/virtual-routes/package.jsonpackages/server-functions-plugin/package.jsone2e/react-start/server-functions/package.jsonpackages/react-router/package.jsone2e/react-router/js-only-file-based/package.jsonexamples/react/authenticated-routes/package.jsone2e/solid-start/custom-basepath/package.jsonexamples/react/with-trpc/package.jsone2e/vue-router/basic/package.jsonexamples/react/start-clerk-basic/package.jsonpackages/router-core/package.jsonexamples/solid/search-validator-adapters/package.jsonexamples/solid/start-basic-nitro/package.jsonexamples/react/start-convex-trellaux/package.jsonexamples/solid/quickstart-file-based/package.jsonexamples/solid/start-basic-static/package.jsone2e/solid-start/spa-mode/package.jsonexamples/react/start-tailwind-v4/package.jsonexamples/react/basic-default-search-params/package.jsonexamples/react/basic-devtools-panel/package.jsonpackages/router-utils/package.jsonexamples/react/deferred-data/package.jsone2e/solid-router/scroll-restoration-sandbox-vite/package.jsonpackages/start-server-core/package.jsonexamples/react/location-masking/package.jsonpackages/vue-router/package.jsonexamples/react/start-large/package.jsone2e/solid-router/js-only-file-based/package.jsonpackages/start-plugin-core/package.jsone2e/react-start/serialization-adapters/package.jsonexamples/solid/basic-default-search-params/package.jsonexamples/solid/router-monorepo-solid-query/packages/router/package.jsone2e/solid-router/basic-virtual-file-based/package.jsonexamples/solid/with-framer-motion/package.jsonexamples/solid/navigation-blocking/package.jsonexamples/solid/router-monorepo-solid-query/package.jsonexamples/solid/router-monorepo-solid-query/packages/post-feature/package.jsonexamples/solid/basic-solid-query/package.jsonpackages/router-plugin/package.jsonexamples/react/view-transitions/package.jsone2e/solid-start/scroll-restoration/package.jsonexamples/solid/large-file-based/package.jsone2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.jsonexamples/react/large-file-based/package.jsonexamples/react/quickstart-rspack-file-based/package.jsonexamples/react/basic-file-based/package.jsonpackages/router-generator/package.jsonexamples/solid/authenticated-routes/package.jsone2e/solid-router/basic-scroll-restoration/package.jsone2e/react-start/scroll-restoration/package.jsonpackages/nitro-v2-vite-plugin/package.jsone2e/react-router/basic-react-query-file-based/package.jsonexamples/react/basic-ssr-streaming-file-based/package.jsonpackages/eslint-plugin-router/package.jsonpackages/react-start/package.jsonexamples/react/kitchen-sink/package.jsonpackages/vue-router-devtools/package.jsone2e/react-router/generator-cli-only/package.jsonpackages/vue-router-ssr-query/package.jsone2e/react-router/basic-react-query/package.jsone2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.jsonpackages/react-start-client/package.jsonexamples/solid/basic-solid-query-file-based/package.jsonpackages/virtual-file-routes/package.jsonpackages/router-ssr-query-core/package.jsone2e/solid-router/rspack-basic-file-based/package.jsonpackages/react-router-devtools/package.jsone2e/solid-router/view-transitions/package.jsonexamples/solid/start-bun/package.jsonexamples/solid/start-basic-auth/package.jsone2e/react-start/virtual-routes/package.jsone2e/solid-router/basic/package.jsonexamples/solid/start-large/package.jsonpackages/router-devtools-core/package.jsone2e/solid-router/basic-solid-query/package.jsone2e/solid-start/website/package.jsonexamples/solid/kitchen-sink-solid-query/package.jsone2e/react-router/basic-file-based-code-splitting/package.jsonexamples/react/search-validator-adapters/package.jsone2e/react-router/sentry-integration/package.jsone2e/solid-router/generator-cli-only/package.jsonpackages/solid-start-client/package.jsone2e/react-router/scroll-restoration-sandbox-vite/package.jsonexamples/react/kitchen-sink-file-based/package.jsone2e/solid-router/basic-virtual-named-export-config-file-based/package.jsonexamples/react/scroll-restoration/package.jsonexamples/solid/kitchen-sink/package.jsonexamples/react/start-basic/package.jsonexamples/solid/basic-devtools-panel/package.jsonexamples/react/start-bun/package.jsone2e/react-router/basic-virtual-file-based/package.jsonexamples/react/quickstart-file-based/package.jsone2e/solid-router/basic-file-based-code-splitting/package.jsone2e/react-router/basic-virtual-named-export-config-file-based/package.jsonexamples/solid/start-i18n-paraglide/package.jsonpackages/router-cli/package.jsonexamples/solid/start-tailwind-v4/package.jsone2e/react-start/custom-basepath/package.jsonexamples/react/basic-react-query/package.jsonexamples/solid/router-monorepo-solid-query/packages/app/package.jsonexamples/react/basic-virtual-inside-file-based/package.jsone2e/react-router/basic-scroll-restoration/package.jsonexamples/react/start-basic-react-query/package.jsone2e/react-router/view-transitions/package.jsonexamples/react/start-basic-auth/package.jsonpackages/router-devtools/package.jsone2e/solid-start/selective-ssr/package.jsonexamples/react/with-trpc-react-query/package.jsone2e/react-start/website/package.jsonexamples/react/with-framer-motion/package.jsonexamples/vue/basic/package.jsonexamples/react/basic-non-nested-devtools/package.jsonexamples/solid/deferred-data/package.jsonexamples/solid/basic-virtual-file-based/package.jsonexamples/solid/start-basic-cloudflare/package.jsonexamples/solid/quickstart-rspack-file-based/package.jsonexamples/solid/router-monorepo-solid-query/packages/post-query/package.jsonexamples/solid/basic-file-based/package.jsonexamples/react/basic/package.jsonpackages/zod-adapter/package.jsone2e/react-start/basic-auth/package.jsonexamples/react/start-basic-authjs/package.jsonexamples/solid/with-trpc/package.jsonexamples/react/start-basic-cloudflare/package.jsone2e/react-start/selective-ssr/package.jsonpackages/start-client-core/package.jsonexamples/solid/view-transitions/package.jsone2e/react-start/server-routes/package.jsonpackages/solid-start-server/package.jsone2e/solid-router/sentry-integration/package.jsonexamples/solid/start-basic-solid-query/package.jsonpackages/router-vite-plugin/package.jsonpackages/start-storage-context/package.jsonexamples/solid/start-supabase-basic/package.jsonpackages/valibot-adapter/package.jsonpackages/solid-router/package.jsonexamples/react/quickstart/package.jsonexamples/react/authenticated-routes-firebase/package.jsonexamples/react/start-i18n-paraglide/package.jsonexamples/vue/basic-file-based-jsx/package.jsonpackages/solid-start/package.jsonpackages/react-router-ssr-query/package.jsonpackage.jsone2e/react-start/spa-mode/package.jsonexamples/react/kitchen-sink-react-query-file-based/package.jsonexamples/solid/authenticated-routes-firebase/package.jsonpackages/history/package.jsone2e/vue-router/basic-file-based-jsx/package.jsone2e/solid-start/basic-solid-query/package.jsonexamples/solid/start-basic-authjs/package.jsone2e/solid-router/basic-solid-query-file-based/package.jsone2e/react-start/basic/package.jsonexamples/solid/basic-ssr-streaming-file-based/package.jsone2e/vue-router/basic-file-based-sfc/package.jsonexamples/solid/scroll-restoration/package.jsone2e/solid-router/basic-file-based/package.jsonpackages/react-start-server/package.jsonexamples/solid/i18n-paraglide/package.jsonexamples/solid/basic/package.jsonexamples/react/start-trellaux/package.jsonpackages/directive-functions-plugin/package.jsonexamples/react/start-supabase-basic/package.jsone2e/solid-start/basic/package.jsone2e/solid-start/basic-cloudflare/package.jsonexamples/solid/router-monorepo-simple-lazy/packages/post-feature/package.jsone2e/react-start/basic-rsc/package.jsonpackages/arktype-adapter/package.jsonexamples/react/kitchen-sink-react-query/package.jsonexamples/solid/kitchen-sink-solid-query-file-based/package.jsonexamples/solid/quickstart/package.json
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript strict mode with extensive type safety for all code
Files:
examples/react/start-clerk-basic/src/routeTree.gen.ts
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Implement ESLint rules for router best practices using the ESLint plugin router
Files:
examples/react/start-clerk-basic/src/routeTree.gen.ts
🧠 Learnings (6)
📚 Learning: 2025-10-01T18:31:35.420Z
Learnt from: schiller-manuel
Repo: TanStack/router PR: 5330
File: e2e/react-start/custom-basepath/src/routeTree.gen.ts:58-61
Timestamp: 2025-10-01T18:31:35.420Z
Learning: Do not review files named `routeTree.gen.ts` in TanStack Router repositories, as these are autogenerated files that should not be manually modified.
Applied to files:
packages/router-core/package.jsonpackages/router-generator/package.jsonpackages/eslint-plugin-router/package.jsonpackages/virtual-file-routes/package.jsonpackages/solid-router/package.jsonpackage.jsonexamples/react/start-clerk-basic/src/routeTree.gen.ts
📚 Learning: 2025-10-08T08:11:47.088Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5402
File: packages/router-generator/tests/generator/no-formatted-route-tree/routeTree.nonnested.snapshot.ts:19-21
Timestamp: 2025-10-08T08:11:47.088Z
Learning: Test snapshot files in the router-generator tests directory (e.g., files matching the pattern `packages/router-generator/tests/generator/**/routeTree*.snapshot.ts` or `routeTree*.snapshot.js`) should not be modified or have issues flagged, as they are fixtures used to verify the generator's output and are intentionally preserved as-is.
Applied to files:
examples/solid/router-monorepo-solid-query/packages/router/package.json
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.
Applied to files:
examples/solid/router-monorepo-solid-query/packages/router/package.jsonpackages/solid-start-client/package.jsonexamples/react/start-clerk-basic/src/routeTree.gen.tse2e/react-start/basic-rsc/package.json
📚 Learning: 2025-12-06T15:03:07.210Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.210Z
Learning: Applies to **/*.{ts,tsx} : Use TypeScript strict mode with extensive type safety for all code
Applied to files:
examples/react/authenticated-routes/tsconfig.jsonexamples/react/authenticated-routes-firebase/tsconfig.json
📚 Learning: 2025-12-06T15:03:07.210Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.210Z
Learning: Applies to **/*.{js,ts,tsx} : Implement ESLint rules for router best practices using the ESLint plugin router
Applied to files:
examples/react/authenticated-routes/tsconfig.jsonexamples/react/authenticated-routes-firebase/tsconfig.jsonexamples/solid/quickstart-rspack-file-based/package.jsonexamples/react/start-clerk-basic/src/routeTree.gen.ts
📚 Learning: 2025-12-06T15:03:07.210Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.210Z
Learning: Applies to **/package.json : Use workspace protocol `workspace:*` for internal dependencies in package.json files
Applied to files:
examples/solid/router-monorepo-simple-lazy/packages/post-feature/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
| "@rsbuild/plugin-solid": "^1.0.6", | ||
| "@tailwindcss/postcss": "^4.1.15", | ||
| "@tanstack/router-e2e-utils": "workspace:^", | ||
| "@tanstack/router-plugin": "workspace:^", | ||
| "postcss": "^8.5.1", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd e2e/solid-router/rspack-basic-file-based && git diff package.jsonRepository: TanStack/router
Length of output: 41
🌐 Web query:
@rsbuild/plugin-solid version 1.0.6 npm package
💡 Result:
@rsbuild/plugin-solid v1.0.6 is published on npm (install: npm i @rsbuild/plugin-solid). It’s MIT-licensed, repo github.com/web-infra-dev/rsbuild, and shows ~1.6–1.9K weekly downloads. (Last published metadata listed in package pages/third‑party scanners; see sources.) [1][2][3]
Sources:
- npm package listing. [1]
- Rsbuild docs / plugin page. [2]
- Socket.dev package page (metadata / last update). [3]
🏁 Script executed:
git log --oneline -n 20 -- e2e/solid-router/rspack-basic-file-based/package.jsonRepository: TanStack/router
Length of output: 87
🏁 Script executed:
git show HEAD:e2e/solid-router/rspack-basic-file-based/package.json | grep -A 2 -B 2 "@rsbuild/plugin-solid"Repository: TanStack/router
Length of output: 255
🏁 Script executed:
git show HEAD~1:e2e/solid-router/rspack-basic-file-based/package.json | grep -A 5 "@rsbuild/plugin-solid"Repository: TanStack/router
Length of output: 95
🏁 Script executed:
git diff HEAD~1 HEAD -- e2e/solid-router/rspack-basic-file-based/package.jsonRepository: TanStack/router
Length of output: 89
🏁 Script executed:
git log --all --oneline -- e2e/solid-router/rspack-basic-file-based/package.json | head -5Repository: TanStack/router
Length of output: 345
🏁 Script executed:
cat e2e/solid-router/rspack-basic-file-based/package.json | sed -n '20,30p'Repository: TanStack/router
Length of output: 389
🏁 Script executed:
git show dcdc99a48:e2e/solid-router/rspack-basic-file-based/package.json | sed -n '20,30p'Repository: TanStack/router
Length of output: 389
🏁 Script executed:
git show 818a4ee8c:e2e/solid-router/rspack-basic-file-based/package.json | sed -n '20,30p'Repository: TanStack/router
Length of output: 389
Both @rsbuild/plugin-solid and tailwindcss were updated in this change.
This commit updated @rsbuild/plugin-solid from ^1.0.4 to ^1.0.6 and tailwindcss from ^4.1.15 to ^4.1.17. If a summary claimed only tailwindcss was modified, it incorrectly omitted the @rsbuild/plugin-solid update. Both changes should be documented.
🤖 Prompt for AI Agents
In e2e/solid-router/rspack-basic-file-based/package.json around lines 22 to 27,
the package updates include both "@rsbuild/plugin-solid" (from ^1.0.4 → ^1.0.6)
and "tailwindcss" (from ^4.1.15 → ^4.1.17) but the commit/summary only
referenced tailwindcss; update the commit message/PR description to explicitly
mention both dependency changes, e.g., note the bump of @rsbuild/plugin-solid to
^1.0.6 and tailwindcss to ^4.1.17, and ensure any release notes or changelog
entries reflect both updates.
| "@types/node": "^22.10.2", | ||
| "postcss": "^8.5.1", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n e2e/solid-start/basic-cloudflare/package.jsonRepository: TanStack/router
Length of output: 1351
Bump "@tailwindcss/postcss" to ^4.1.17 to align with tailwindcss version.
The "@tailwindcss/postcss" dependency is currently at ^4.1.15 (line 24) while tailwindcss is at ^4.1.17 (line 28). Update it to match.
🤖 Prompt for AI Agents
In e2e/solid-start/basic-cloudflare/package.json around lines 24 to 28, the
"@tailwindcss/postcss" dependency is pinned to ^4.1.15 while "tailwindcss" is
^4.1.17; update the "@tailwindcss/postcss" version string to ^4.1.17 so both
match, then run your package manager to update the lockfile (npm/yarn/pnpm) and
commit the updated lockfile.
| "postcss": "^8.5.1", | ||
| "redaxios": "^0.5.1", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat e2e/vue-router/basic-file-based-sfc/package.jsonRepository: TanStack/router
Length of output: 1031
Align @tailwindcss/postcss version to match tailwindcss.
Update "@tailwindcss/postcss" from ^4.1.15 to ^4.1.17 to match the tailwindcss version in this package.
🤖 Prompt for AI Agents
In e2e/vue-router/basic-file-based-sfc/package.json around line 21, the
@tailwindcss/postcss dependency version is out of sync with tailwindcss; update
the "@tailwindcss/postcss" entry from ^4.1.15 to ^4.1.17 so both packages use
the same 4.1.17 version, then run npm/yarn install to refresh lockfile and
ensure compatibility.
| }, | ||
| "dependencies": { | ||
| "@tailwindcss/vite": "^4.1.13", | ||
| "@tailwindcss/vite": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n examples/react/i18n-paraglide/package.jsonRepository: TanStack/router
Length of output: 1001
🏁 Script executed:
find examples -name "package.json" -type f | head -20Repository: TanStack/router
Length of output: 1067
🏁 Script executed:
grep -r "tailwindcss" examples/react/*/package.json | grep -E '"(tailwindcss|@tailwindcss)'Repository: TanStack/router
Length of output: 7119
🌐 Web query:
@tailwindcss/vite 4.1.17 tailwindcss 4.1.13 compatibility
💡 Result:
Yes — @tailwindcss/vite 4.1.17 is intended for Tailwind CSS v4 and is compatible with tailwindcss 4.1.13. (The main compatibility concern for @tailwindcss/vite v4.x is Vite's version: the plugin declares a peer dependency on vite "^5.2.0 || ^6", which can cause install errors with Vite 7.) [1][2]
Sources:
- @tailwindcss/vite (npm package / v4.x info). [1]
- Discussion/issue noting @tailwindcss/vite v4 peerDependency on Vite (^5.2.0 || ^6). [2]
@tailwindcss/vite ^4.1.17 has a peer dependency conflict with vite ^7.1.7.
The @tailwindcss/vite v4.x package declares a peer dependency on vite "^5.2.0 || ^6", but this project uses vite ^7.1.7. This will cause installation errors. The patch-level difference between @tailwindcss/vite and tailwindcss (4.1.17 vs 4.1.13) is compatible and not the issue.
| }, | ||
| "dependencies": { | ||
| "@tailwindcss/vite": "^4.1.13", | ||
| "@tailwindcss/vite": "^4.1.17", |
There was a problem hiding this comment.
Critical: Mismatched Tailwind CSS package versions.
Line 16 updates @tailwindcss/vite to ^4.1.17, but line 25 leaves tailwindcss at ^4.1.13. This version mismatch is precisely the type of dependency inconsistency that publint and sherif CI checks flag as problematic. Both packages should be aligned to the same minor/patch version to ensure compatibility.
Apply this diff to align the versions:
- "tailwindcss": "^4.1.13",
+ "tailwindcss": "^4.1.17",Also applies to: 25-25
🤖 Prompt for AI Agents
In examples/react/start-bun/package.json around lines 16 and 25, the
@tailwindcss/vite dependency at line 16 is bumped to ^4.1.17 while tailwindcss
at line 25 remains ^4.1.13, causing a version mismatch that fails CI; update the
tailwindcss entry to ^4.1.17 (or alternatively align both to the same target
version) in package.json, then regenerate the lockfile (npm/yarn/pnpm install)
to persist the change and run the test/CI checks to verify compatibility.
| "redaxios": "^0.5.1", | ||
| "solid-js": "^1.9.10", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n examples/solid/basic-solid-query-file-based/package.json | head -30Repository: TanStack/router
Length of output: 1085
🏁 Script executed:
cd examples/solid/basic-solid-query-file-based && jq -r '.dependencies["@tailwindcss/postcss"] // .devDependencies["@tailwindcss/postcss"] // "MISSING"' package.jsonRepository: TanStack/router
Length of output: 66
🏁 Script executed:
fd -e package.json -x grep -l "@tailwindcss/postcss" {}Repository: TanStack/router
Length of output: 41
🏁 Script executed:
fd -e package.json -x sh -c 'echo "File: {}"; jq -r ".dependencies[\"@tailwindcss/postcss\"] // .devDependencies[\"@tailwindcss/postcss\"] // \"MISSING\"" "$1"' _ {}Repository: TanStack/router
Length of output: 41
Update "@tailwindcss/postcss" to ^4.1.17 for parity with tailwindcss.
The "@tailwindcss/postcss" dependency (line 13) is currently at ^4.1.15 while tailwindcss (line 21) is at ^4.1.17. These should be kept in sync.
🤖 Prompt for AI Agents
In examples/solid/basic-solid-query-file-based/package.json around lines 13 and
21, the @tailwindcss/postcss dependency at line 13 is pinned to ^4.1.15 while
tailwindcss at line 21 is ^4.1.17; update the @tailwindcss/postcss entry to
^4.1.17 so both Tailwind-related packages are in parity and then run npm/yarn
install to refresh lockfile.
| "@types/node": "^22.5.4", | ||
| "postcss": "^8.5.1", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat examples/solid/start-basic-authjs/package.json | head -40Repository: TanStack/router
Length of output: 901
Update @tailwindcss/postcss to match tailwindcss version.
@tailwindcss/postcss is currently at ^4.1.15; update to ^4.1.17 to keep the toolchain aligned with tailwindcss.
🤖 Prompt for AI Agents
In examples/solid/start-basic-authjs/package.json around line 25, the
@tailwindcss/postcss dependency is out of sync with tailwindcss (postcss is
^4.1.15 while tailwindcss is ^4.1.17); update the @tailwindcss/postcss version
specifier to ^4.1.17 in package.json so both packages use the same minor/patch
version, then run package manager install (npm/yarn/pnpm) and verify lockfile
updates and a build to ensure compatibility.
| "postcss": "^8.5.1", | ||
| "redaxios": "^0.5.1", | ||
| "tailwindcss": "^4.1.15", | ||
| "tailwindcss": "^4.1.17", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat examples/vue/basic-file-based-sfc/package.json | grep -E '(tailwindcss|@tailwindcss/postcss)' -nRepository: TanStack/router
Length of output: 133
Align @tailwindcss/postcss version with tailwindcss.
@tailwindcss/postcss is currently at ^4.1.15 while tailwindcss is ^4.1.17. Bump @tailwindcss/postcss to ^4.1.17 to maintain consistency and avoid tooling skew between closely coupled packages.
🤖 Prompt for AI Agents
In examples/vue/basic-file-based-sfc/package.json around line 19, the
@tailwindcss/postcss dependency is out of sync with tailwindcss; update the
@tailwindcss/postcss version from ^4.1.15 to ^4.1.17 in package.json to match
tailwindcss, then run your package manager (npm/yarn/pnpm) to install and update
the lockfile so dependencies stay consistent.
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/react/start-basic-rsc/package.json (1)
13-15: Internal TanStack dependencies must use workspace protocol, not hardcoded versions.Per coding guidelines, internal dependencies should use
workspace:^rather than pinned version numbers. The following dependencies should be updated:
@tanstack/react-router@tanstack/react-router-devtools@tanstack/react-startApply this diff:
"dependencies": { "@babel/plugin-syntax-typescript": "^7.25.9", - "@tanstack/react-router": "^1.132.0-alpha.25", - "@tanstack/react-router-devtools": "^1.132.0-alpha.25", - "@tanstack/react-start": "^1.132.0-alpha.25", + "@tanstack/react-router": "workspace:^", + "@tanstack/react-router-devtools": "workspace:^", + "@tanstack/react-start": "workspace:^", "react": "^19.0.0",
🧹 Nitpick comments (1)
e2e/react-start/basic-rsc/package.json (1)
23-23: Synchronize tailwindcss versions across devDependencies.
@tailwindcss/postcssis pinned to^4.1.15whiletailwindcssis pinned to^4.1.17. These should be kept in sync given the PR-wide tailwindcss version bumps to^4.1.17.Apply this diff:
- "@tailwindcss/postcss": "^4.1.15", + "@tailwindcss/postcss": "^4.1.17",Also applies to: 29-29
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (17)
e2e/react-start/basic-rsc/package.json(1 hunks)e2e/react-start/clerk-basic/package.json(1 hunks)examples/react/authenticated-routes-firebase/src/main.tsx(1 hunks)examples/react/authenticated-routes-firebase/src/routes/__root.tsx(0 hunks)examples/react/authenticated-routes-firebase/src/routes/_auth.dashboard.tsx(0 hunks)examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.$invoiceId.tsx(0 hunks)examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.index.tsx(0 hunks)examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.tsx(0 hunks)examples/react/authenticated-routes-firebase/src/routes/login.tsx(1 hunks)examples/react/authenticated-routes/src/routes/__root.tsx(0 hunks)examples/react/authenticated-routes/src/routes/_auth.dashboard.tsx(0 hunks)examples/react/authenticated-routes/src/routes/_auth.invoices.$invoiceId.tsx(0 hunks)examples/react/authenticated-routes/src/routes/_auth.invoices.index.tsx(0 hunks)examples/react/authenticated-routes/src/routes/_auth.invoices.tsx(0 hunks)examples/react/authenticated-routes/src/routes/_auth.tsx(0 hunks)examples/react/authenticated-routes/src/routes/index.tsx(0 hunks)examples/react/start-basic-rsc/package.json(1 hunks)
💤 Files with no reviewable changes (12)
- examples/react/authenticated-routes/src/routes/_auth.invoices.$invoiceId.tsx
- examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.$invoiceId.tsx
- examples/react/authenticated-routes/src/routes/__root.tsx
- examples/react/authenticated-routes/src/routes/_auth.tsx
- examples/react/authenticated-routes/src/routes/_auth.invoices.index.tsx
- examples/react/authenticated-routes-firebase/src/routes/__root.tsx
- examples/react/authenticated-routes/src/routes/_auth.invoices.tsx
- examples/react/authenticated-routes-firebase/src/routes/_auth.dashboard.tsx
- examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.tsx
- examples/react/authenticated-routes/src/routes/index.tsx
- examples/react/authenticated-routes/src/routes/_auth.dashboard.tsx
- examples/react/authenticated-routes-firebase/src/routes/_auth.invoices.index.tsx
🧰 Additional context used
📓 Path-based instructions (3)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Use workspace protocol
workspace:*for internal dependencies in package.json files
Files:
e2e/react-start/clerk-basic/package.jsone2e/react-start/basic-rsc/package.jsonexamples/react/start-basic-rsc/package.json
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript strict mode with extensive type safety for all code
Files:
examples/react/authenticated-routes-firebase/src/routes/login.tsxexamples/react/authenticated-routes-firebase/src/main.tsx
**/*.{js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Implement ESLint rules for router best practices using the ESLint plugin router
Files:
examples/react/authenticated-routes-firebase/src/routes/login.tsxexamples/react/authenticated-routes-firebase/src/main.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: schiller-manuel
Repo: TanStack/router PR: 5330
File: packages/router-core/src/router.ts:2231-2245
Timestamp: 2025-10-01T18:30:26.591Z
Learning: In `packages/router-core/src/router.ts`, the `resolveRedirect` method intentionally strips the router's origin from redirect URLs when they match (e.g., `https://foo.com/bar` → `/bar` for same-origin redirects) while preserving the full URL for cross-origin redirects. This logic should not be removed or simplified to use `location.publicHref` directly.
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad
Repo: TanStack/router PR: 5732
File: packages/start-client-core/src/client/hydrateStart.ts:6-9
Timestamp: 2025-11-02T16:16:24.898Z
Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.
Applied to files:
e2e/react-start/basic-rsc/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (4)
examples/react/authenticated-routes-firebase/src/main.tsx (1)
6-6: Auth import cleanup is correctDropping the unused
AuthContextType(type-only import) from this file is safe and keeps the runtime import surface minimal; nothing in this module references that type, so this should help keep publint/TS happy without changing behavior.e2e/react-start/basic-rsc/package.json (1)
13-15: Workspace protocol correctly applied to internal dependencies.All TanStack packages use the
workspace:^protocol as required by coding guidelines. This ensures internal dependencies resolve to the workspace versions.examples/react/authenticated-routes-firebase/src/routes/login.tsx (1)
2-8: Import cleanup correctly matches usage and should satisfy publint/sherif
redirect,useRouter,siGithub, andGithubAuthProviderare all used in this file, and previously unused symbols have been removed. This keeps the example lean and should address the CI/lint complaints without changing runtime behavior.Please re-run publint/sherif locally to confirm there are no remaining complaints for this example after the import adjustments.
e2e/react-start/clerk-basic/package.json (1)
14-17: Internal TanStack dependencies correctly use workspace protocol.The
workspace:^references for@tanstack/react-router,@tanstack/react-router-devtools,@tanstack/react-start, and@tanstack/router-e2e-utilsare properly scoped to the monorepo.Also applies to: 26-26
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite dev", | ||
| "build": "exit 0; vite build", |
There was a problem hiding this comment.
Fix the build script — exit 0 prevents vite build from executing.
The build script runs exit 0 which terminates with success status before vite build can execute, effectively disabling the build step. This appears to be a placeholder or workaround.
Apply this diff to enable the build:
- "build": "exit 0; vite build",
+ "build": "vite build",If exit 0 was intentional (e.g., for skipping builds in CI), clarify the intent or use a more explicit approach.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "build": "exit 0; vite build", | |
| "build": "vite build", |
🤖 Prompt for AI Agents
In e2e/react-start/basic-rsc/package.json around line 8, the build script
currently uses "exit 0; vite build" which causes the script to exit before
running Vite; remove the leading "exit 0;" so the script runs "vite build" (or,
if skipping builds intentionally, replace with a clear conditional/CI-specific
skip or a no-op script name and document the reason). Ensure package.json's
build script runs the actual build command and update any CI configs if they
relied on the previous placeholder.
| "dev": "vite dev --port 3000", | ||
| "dev:e2e": "vite dev", | ||
| "build": "vite build", | ||
| "build": "exit 0; vite build", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n e2e/react-start/clerk-basic/package.jsonRepository: TanStack/router
Length of output: 1418
🏁 Script executed:
# Find other e2e package.json files with similar patterns
fd -t f "package.json" e2e/ --exec grep -l "exit 0" {}
# Also check the git log for context around this change
git log --oneline -n 20 -- e2e/react-start/clerk-basic/package.jsonRepository: TanStack/router
Length of output: 262
🏁 Script executed:
# Get full commit message for the "Fix CI" commit
git show 83abc654d --stat
# Check another e2e package.json to see if the pattern is identical
cat -n e2e/react-start/basic-auth/package.json | head -20Repository: TanStack/router
Length of output: 50372
🏁 Script executed:
# Check another e2e package
cat -n e2e/react-start/basic-auth/package.json | head -15
# Look for any documentation or comments in e2e directory
find e2e -maxdepth 2 -name "README*" -o -name "*.md" | head -10Repository: TanStack/router
Length of output: 632
🏁 Script executed:
# Check the build scripts specifically in the e2e packages that had exit 0
for file in e2e/react-start/basic-rsc/package.json e2e/solid-start/basic-auth/package.json e2e/e2e-utils/package.json; do
if [ -f "$file" ]; then
echo "=== $file ==="
grep -A2 '"build"' "$file"
fi
doneRepository: TanStack/router
Length of output: 485
🏁 Script executed:
# Search for any TODOs, FIXMEs, or comments related to exit 0 in the file
cd e2e/react-start/clerk-basic && find . -type f \( -name "*.ts" -o -name "*.tsx" -o -name "*.js" -o -name "*.json" -o -name "*.md" \) -exec grep -l "exit\|build\|publint\|sherif" {} \; 2>/dev/null | head -20
# Also check for any comments in the package.json itself or nearby
cd /repo && cat -n e2e/react-start/clerk-basic/package.json | grep -B2 -A2 "build"Repository: TanStack/router
Length of output: 169
🏁 Script executed:
# Check playwright.config.ts for any clues
cat -n e2e/react-start/clerk-basic/playwright.config.ts | head -50
# Search git history for when exit 0 was introduced in build scripts
git log --all --oneline --grep="build\|exit" -i | head -20
# Check the specific commit that added these packages
git show 83abc654d --name-only | grep "clerk-basic\|basic-rsc"Repository: TanStack/router
Length of output: 9589
🏁 Script executed:
# Let me verify the build directory expectations
cat -n e2e/react-start/clerk-basic/package.json | grep -A2 -B2 "start"
# Check if there are any error logs or CI failures related to this
git log --all --oneline --since="2025-12-01" -- e2e/react-start/clerk-basic/ | head -10Repository: TanStack/router
Length of output: 738
The build script prevents the test server from starting.
The exit 0; vite build pattern exits before Vite builds the application, which is needed for the playwright test server. Since playwright.config.ts runs pnpm build && pnpm start, skipping the build means the .output/server/index.mjs file won't exist and the server startup will fail. This will break all e2e tests for this package.
Either:
- Remove the
exit 0;prefix to allow the actual build to run - If intentionally disabling builds, explain why and update the test configuration accordingly
- If this is a temporary CI workaround, add a TODO comment with context and a ticket reference
🤖 Prompt for AI Agents
In e2e/react-start/clerk-basic/package.json around line 9, the build script uses
"exit 0; vite build" which prevents Vite from actually producing the build
artifacts required by the Playwright test server; remove the "exit 0;" prefix so
the script runs the real build (i.e., change to just run the build command), or
if builds must be disabled intentionally, add a clear TODO comment with
rationale and ticket reference and update playwright.config.ts to not run pnpm
build (or to skip this package) so tests don't expect .output/server/index.mjs.
| "scripts": { | ||
| "dev": "vite dev", | ||
| "build": "vite build", | ||
| "build": "exit 0; vite build", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n examples/react/start-basic-rsc/package.jsonRepository: TanStack/router
Length of output: 1350
🏁 Script executed:
cat pnpm-workspace.yaml 2>/dev/null || cat -n package.json | head -30Repository: TanStack/router
Length of output: 468
🏁 Script executed:
fd "package.json" examples/react/ --exec grep -l "@tanstack" {}Repository: TanStack/router
Length of output: 3437
🏁 Script executed:
# Check a couple of other examples to see if they use workspace:* protocol
head -20 examples/react/kitchen-sink/package.json 2>/dev/null || echo "File not found"Repository: TanStack/router
Length of output: 611
🏁 Script executed:
grep -r "exit 0;" examples/react/ e2e/react-start/ --include="package.json" 2>/dev/null | head -20Repository: TanStack/router
Length of output: 554
Fix the build script that exits before running Vite.
The exit 0; vite build command terminates the script before vite build executes, effectively skipping the actual build step. This same pattern appears in multiple e2e packages (clerk-basic, basic-rsc) and basic-auth, suggesting a systematic workaround. Either remove the exit 0; to allow the build to run, or provide documentation explaining why builds are intentionally skipped.
🤖 Prompt for AI Agents
In examples/react/start-basic-rsc/package.json around line 8, the build script
currently uses "exit 0; vite build" which exits immediately and prevents Vite
from running; remove the "exit 0;" prefix so the script runs "vite build"
directly (or replace with a conditional/no-op only when explicitly needed) and
apply the same change to the other e2e package.json files (clerk-basic,
basic-rsc, basic-auth) or add a README note explaining why builds should be
skipped if that was intentional.
lachlancollins
changed the title
* Update repository URLs * Start sherif fixes * Fic CI
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.