Skip to content

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD release workflow configuration and job naming.
    • Optimized workspace package management settings and expanded the development workspace to include additional utilities and example packages.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

Workflow job renamed from "test" to "release" in GitHub Actions. Workspace configuration refactored by removing npm-level workspace settings from .npmrc and migrating equivalent options to pnpm-level configuration in pnpm-workspace.yaml. Package globs expanded to include additional examples and e2e utilities.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/release.yml
Job key renamed from test to release; workflow logic, steps, and conditions unchanged
Workspace Configuration
.npmrc, pnpm-workspace.yaml
Removed npm-level workspace options (link-workspace-packages, prefer-workspace-packages) from .npmrc; added equivalent pnpm-level flags (cleanupUnusedCatalogs, linkWorkspacePackages, preferWorkspacePackages) to pnpm-workspace.yaml; expanded packages glob patterns

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the pnpm workspace flags correctly replace the npm configuration options and produce equivalent behavior
  • Confirm the expanded package globs in pnpm-workspace.yaml accurately target all intended example and e2e packages
  • Ensure the workflow job rename doesn't break any external references or CI/CD integrations

Possibly related PRs

Poem

🐰 Config hops from npm to pnpm's domain,
Workspace flags consolidated—cleaner terrain,
Job renamed with care, the workflow stays true,
A tidy refactor, through and through! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving pnpm settings from .npmrc to pnpm-workspace.yaml, which aligns with the file modifications shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pnpm-settings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcce02c and 7fd3ca0.

📒 Files selected for processing (3)
  • .github/workflows/release.yml (1 hunks)
  • .npmrc (0 hunks)
  • pnpm-workspace.yaml (1 hunks)
💤 Files with no reviewable changes (1)
  • .npmrc
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.223Z
Learning: Applies to **/package.json : Use workspace protocol `workspace:*` for internal dependencies in package.json files
📚 Learning: 2025-12-06T15:03:07.223Z
Learnt from: CR
Repo: TanStack/router PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T15:03:07.223Z
Learning: Applies to **/package.json : Use workspace protocol `workspace:*` for internal dependencies in package.json files

Applied to files:

  • pnpm-workspace.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Preview
🔇 Additional comments (3)
pnpm-workspace.yaml (2)

5-19: Package glob patterns are well-structured.

The comprehensive package glob patterns correctly include core packages, example monorepos, and e2e utilities, which aligns with the expanded workspace scope mentioned in the PR objectives.


1-3: Configuration migration is correct and complete.

The workspace optimization settings are properly placed in pnpm-workspace.yaml, and conflicting settings have been removed from .npmrc. The three flags (cleanupUnusedCatalogs, linkWorkspacePackages, preferWorkspacePackages) enable efficient workspace dependency linking and catalog management, improving both local development and CI/CD performance. The monorepo package structure is correctly configured to include all workspace packages.

.github/workflows/release.yml (1)

26-26: No breaking references found for the job ID rename.

The codebase contains no dependencies on the old "test" job ID from release.yml. No other workflows reference this job via needs dependencies, and no status check references were found. The job ID rename from "test" to "release" is safe within the codebase scope. However, verify that any branch protection rules configured in GitHub Settings do not reference the old job name, as these cannot be checked via codebase search.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Dec 12, 2025

View your CI Pipeline Execution ↗ for commit 7fd3ca0

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-12 04:16:14 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 12, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6076

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@6076

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6076

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6076

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6076

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6076

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6076

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6076

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6076

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6076

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6076

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6076

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6076

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6076

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6076

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6076

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6076

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6076

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6076

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6076

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@6076

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6076

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6076

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6076

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6076

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6076

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6076

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6076

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6076

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6076

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6076

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6076

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6076

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6076

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6076

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6076

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6076

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6076

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6076

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6076

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6076

commit: 7fd3ca0

@lachlancollins lachlancollins merged commit b1b8c9e into main Dec 12, 2025
6 checks passed
@lachlancollins lachlancollins deleted the pnpm-settings branch December 12, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants