Skip to content

Conversation

@schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Jan 24, 2026

closes #6483

Summary by CodeRabbit

Release Notes

  • Refactor
    • Consolidated server detection utilities into router-core, streamlining package dependencies and organization.
    • Updated import paths: isServer is now available from @tanstack/router-core/isServer with environment-specific handling maintained.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

This PR consolidates the standalone @tanstack/router-is-server package into @tanstack/router-core by migrating its source files, export configuration, and build setup. References across framework-specific packages are updated to reflect the new consolidated location.

Changes

Cohort / File(s) Summary
Deleted: router-is-server package
packages/router-is-server/package.json, packages/router-is-server/vite.config.ts, packages/router-is-server/eslint.config.js, packages/router-is-server/tsconfig.json, packages/router-is-server/src/client.ts, packages/router-is-server/src/server.ts
Entire standalone package removed as its functionality is consolidated into router-core.
router-core: isServer migration
packages/router-core/src/isServer.ts
Updated to export isServer from new local development module instead of external @tanstack/router-is-server.
router-core: new isServer modules
packages/router-core/src/isServer/client.ts, packages/router-core/src/isServer/server.ts
New files adding isServer exports with environment-specific implementations (client: false, server: true).
router-core: exports & build config
packages/router-core/package.json, packages/router-core/vite.config.ts
Added comprehensive environment-specific export mappings (dev/workerd/worker/browser/deno/node/bun) for isServer. Added three new build entry points in vite config. Removed router-is-server dependency.
Reference updates
labeler-config.yml, packages/react-router/vite.config.ts, packages/solid-router/vite.config.ts, packages/vue-router/vite.config.ts
Updated comments and references to point to @tanstack/router-core/isServer instead of @tanstack/router-is-server.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

  • feat: add isServer #4648: Introduced the initial isServer feature and created the @tanstack/router-is-server package that is now being consolidated into router-core in this PR.

Suggested reviewers

  • birkskyum
  • brenelz

Poem

🐰 A package stood alone, but now finds its way,
Hopping into router-core, where exports hold sway,
From the standalone warren to the central hall,
isServer blooms in every environment—serving all! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: consolidating the isServer export into router-core instead of maintaining it as a separate package.
Linked Issues check ✅ Passed The PR successfully resolves issue #6483 by eliminating the dependency on the unpublished @tanstack/router-is-server package and moving isServer into router-core.
Out of Scope Changes check ✅ Passed All changes are in-scope: removing router-is-server package, moving isServer functionality to router-core, and updating references in dependent packages (react-router, solid-router, vue-router).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Jan 24, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit d5436ab

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 11m 4s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-24 11:52:26 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 24, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@6485

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@6485

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@6485

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@6485

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@6485

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@6485

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@6485

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@6485

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@6485

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@6485

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@6485

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@6485

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@6485

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@6485

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@6485

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@6485

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@6485

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@6485

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@6485

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@6485

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@6485

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@6485

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@6485

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@6485

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@6485

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@6485

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@6485

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@6485

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@6485

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@6485

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@6485

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@6485

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@6485

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@6485

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@6485

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@6485

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@6485

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@6485

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@6485

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@6485

commit: d5436ab

@schiller-manuel schiller-manuel merged commit b953e00 into main Jan 24, 2026
5 of 6 checks passed
@schiller-manuel schiller-manuel deleted the no-additional-package branch January 24, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/router-is-server not published to npm - breaks 1.157.0 installs

2 participants