Skip to content

fix(start): prevent prerender hang when filter returns zero results #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 3 commits into from
Feb 13, 2026
+19 −1
Merged

fix(start): prevent prerender hang when filter returns zero results #6619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b59b79f
fix(prerender): add check for settled queue to skip empty prerender f…
jong-kyung Feb 9, 2026
bc563a6
test(prerender): add test for resolving when prerender filter matches…
jong-kyung Feb 9, 2026
e9ecb92
Merge branch 'main' into fix/filter-time-out
jong-kyung Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/start-plugin-core/src/prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ export async function prerender({

startConfig.pages.forEach((page) => addCrawlPageTask(page))

if (queue.isSettled()) {
logger.info('No pages matched prerender filter; skipping.')
return Array.from(prerendered)
}

await queue.start()

return Array.from(prerendered)
Expand Down
15 changes: 14 additions & 1 deletion packages/start-plugin-core/tests/prerender-ssrf.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ function resetFetch() {

function makeStartConfig(pagePath: string) {
return {
prerender: { enabled: true, autoStaticPathsDiscovery: false },
prerender: {
enabled: true,
autoStaticPathsDiscovery: false,
concurrency: 1,
},
pages: [{ path: pagePath }],
router: { basepath: '' },
spa: {
Expand Down Expand Up @@ -97,4 +101,13 @@ describe('prerender pages validation', () => {

await expect(prerender({ startConfig, builder })).resolves.not.toThrow()
})

it('resolves when prerender filter matches no pages', async () => {
resetFetch()
const startConfig = makeStartConfig('/about')
startConfig.prerender.filter = () => false

await expect(prerender({ startConfig, builder })).resolves.not.toThrow()
expect(fetchMock).not.toHaveBeenCalled()
})
})
Loading