document passing Link isActive to children #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FugiTech
pushed a commit
to FugiTech/router
that referenced
this pull request
Sep 12, 2023
tannerlinsley
pushed a commit
that referenced
this pull request
Sep 12, 2023
* docs: fixed variable name error (#715) used the wrong example in customStringifier example * Fix(router-cli): Fixes on Windows and Improvements (#717) * (fix) Fixed backslash on windows (fix) Sanitized routePaths, import and interface keys (enhanched) made the parent search recursive (question) how layouts need to be generated? * (feat) Added WIP example for file routing * (fix) add debug json in ignored * (fix) Added return type to 'hasParentRoute' (fix) Removed example, moved to another branch --------- Co-authored-by: Koja sig. Dennis <DKOJA@ceia-spa.com> * fix: types for useNavigate and useMatchRoute (#723) * document passing Link isActive to children (#725) --------- Co-authored-by: Frank Tran <ftransd@gmail.com> Co-authored-by: Denny09310 <50493437+Denny09310@users.noreply.github.com> Co-authored-by: Koja sig. Dennis <DKOJA@ceia-spa.com> Co-authored-by: Blake Gentry <bgentry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing the source code for the
<Link>component, I stumbled upon the fact that you can propagate theisActiveprop to children if you provide a function for children. This seemed useful enough to document because it turned out to be the exact problem I was trying to solve, and couldn't find an official way to do so other than making my ownLinkcomponent.