getIsSomeRowsSelected should not return false when all rows are selected

TanStack · Jun 30, 2024 · a0f1cc3 · a0f1cc3
1 parent e42f9dd
commit a0f1cc3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/examples/react/row-selection/src/main.tsx b/examples/react/row-selection/src/main.tsx
@@ -1,4 +1,4 @@
-import React, { HTMLAttributes, HTMLProps } from 'react'
+import React, { HTMLProps } from 'react'
 import ReactDOM from 'react-dom/client'
 
 import './index.css'

diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts
@@ -431,22 +431,13 @@ export const RowSelection: TableFeature = {
     }
 
     table.getIsSomeRowsSelected = () => {
-      const totalSelected = Object.keys(
-        table.getState().rowSelection ?? {}
-      ).length
-      return (
-        totalSelected > 0 &&
-        totalSelected <= table.getFilteredRowModel().flatRows.length
-      )
+      return Object.keys(table.getState().rowSelection ?? {}).length > 0
     }
 
     table.getIsSomePageRowsSelected = () => {
-      const paginationFlatRows = table.getPaginationRowModel().flatRows
-      return table.getIsAllPageRowsSelected()
-        ? false
-        : paginationFlatRows
-            .filter(row => row.getCanSelect())
-            .some(d => d.getIsSelected() || d.getIsSomeSelected())
+      return table
+        .getPaginationRowModel()
+        .flatRows.some(r => r.getIsSelected() || r.getIsSomeSelected())
     }
 
     table.getToggleAllRowsSelectedHandler = () => {