Feature: Add columnResizeDirection to support RTL column resizing #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelarbibe
changed the title
2 tasks
AlonMiz
reviewed
Dec 9, 2023
| @@ -152,6 +152,14 @@ columnResizeMode?: 'onChange' | 'onEnd' | |||
|
|
|||
| Determines when the columnSizing state is updated. `onChange` updates the state when the user is dragging the resize handle. `onEnd` updates the state when the user releases the resize handle. | |||
|
|
|||
| ### `columnResizeDirection` | |||
There was a problem hiding this comment.
isnt there a global setting to rtl, that we can depend on instead of allowing rtl specifically for column resizing?
There was a problem hiding this comment.
In another PR, I have introduced a global option rtl that could be used in other places.
But, this is the only feature that requires an explicit rtl setting. Other things can be sorted using CSS properties.
Therefore, I thought it would be more appropriate to make this a feature-specific option.
KevinVandy
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RTL column resizing by adding a
columnResizeDirectionto column resize options, as discussed in #4331