Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: id building was not consistent when using deep accessorKey (4754) #5430

Merged
merged 3 commits into from
Aug 3, 2024
Merged

fix: id building was not consistent when using deep accessorKey (4754) #5430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a3f03f
fix: id building was not consistent when using deep accessorKey (4754)
Roman86 Mar 22, 2024
d925d0c
Merge branch 'main' into fix-deep-accessor-4754
KevinVandy Aug 3, 2024
f68263c
ci: apply automated fixes
autofix-ci[bot] Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/table-core/src/core/column.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ export function createColumn<TData extends RowData, TValue>(

let id =
resolvedColumnDef.id ??
(accessorKey ? accessorKey.replace('.', '_') : undefined) ??
(accessorKey
? typeof String.prototype.replaceAll === 'function'
? accessorKey.replaceAll('.', '_')
: accessorKey.replace(/\./g, '_')
: undefined) ??
(typeof resolvedColumnDef.header === 'string'
? resolvedColumnDef.header
: undefined)
Expand Down