New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coerce accessor key to string during column creation #5808

Open

schardev wants to merge 1 commit into TanStack:main from schardev:fix-accessor-key

schardev commented Nov 19, 2024

This is based on the PR by @jpedroh (#4835)

During render, if the accessorKey was not a string, e.g. a number, it would result in an error when trying to normalize it during column creation, because it was trying to access methods which are not available in a number (replace and include). This PR forces the accessor key to be constructed as a string during column creation, thus removing this bug.

fixes #4815


          fix: coerce accessor key to string during column creation

dcf41d7

Co-authored-by: Joao Pedro Henrique <joao.pedro.hsd@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet