chore: Remove unnecessary console.error log from table.getColumn(id) implementation
#5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation The `getColumn` method is already typed to return `Column<TData, unknown> | undefined`, indicating to callers that the result might be undefined. The current `console.error` logging when a column is not found: 1. Adds noise in development environments 2. Can mask actual issues 3. Forces users to implement workarounds (as discussed in TanStack#5505) This change removes the error logging while maintaining the expected return type, allowing consumers to handle undefined columns as already expected by the API.
mikekobit-stripe
changed the title
console.error log from table.getColumn(id) implementationconsole.error log from table.getColumn(id) implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getColumnmethod is already typed to returnColumn<TData, unknown> | undefined, indicating to callers that the result might be undefined. The currentconsole.errorlogging when a column is not found:This change removes the error logging while maintaining the expected return type, allowing consumers to handle undefined columns as already expected by the API.