fix: update column filtering pagination guide link #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisaragi-hiu
added a commit
to kisaragi-hiu/tanstack-table
that referenced
this pull request
Mar 20, 2025
Would obsolete TanStack#5965, TanStack#5918 if merged. I listed the broken links on my end like this: # utilizing lychee # lychee doesn't support checking links recursively from a web page; # but we do have a kind of sitemap here that we can pass to it. cd tanstack-table/docs/ lychee $(find . -name '*.md' | sed 's~./~https://tanstack.com/table/latest/docs/~;s/.md//') # for the local build; might also want `--timeout 60` lychee $(find . -name '*.md' | sed 's~./~http://localhost:3000/table/latest/docs/~;s/.md//') # sed's separator in 's/from/to/' can be changed to avoid escaping, # so 's~from~to~' has the same effect except slashes can stay as-is. # then s/.md// gets rid of the extension, completing the conversion # to deployed URLs. # (I'm explaining all this because I'm also scared by the xz takeover.) There is some magic with relative links: "../" seems to navigate to "../../" instead (???), while ./ is the current path. As a result every replacement here is manually done and tested with lychee. Exceptional cases are explained in the details section below. When checking the result afterwards, there may be one broken link left if locally only the /tanstack/tanstack.com and /tanstack/table repositories are checked out: from localhost:3000/table/latest/docs/guide/virtualization, linking to localhost:3000/virtual/v3/docs/api/virtualizer. This is an artifact of the way it's checked out. Detailed changes: docs/api/core/{cell,column,header-group,header,row,table}: link to /docs/guide/features currently link to /guide/features instead, and causes a redirect loop. This error is deployed right now: check eg. https://tanstack.com/table/latest/docs/api/core/cell and click the "table features" link. (This is not exceptional, just the first case I tackled.) docs/guide/headers: Aside from fixing paths, also fix an incorrect reference to non-existant Column Resizing Guide at docs/guide/column-resizing; presumably this is misspelling for the Column Sizing Guide at docs/guide/column-sizing. docs/guide/row-selection: Beyond fixing paths, also fix a missing /example/ in the vue example path.
KevinVandy
pushed a commit
that referenced
this pull request
Mar 20, 2025
Would obsolete #5965, #5918 if merged. I listed the broken links on my end like this: # utilizing lychee # lychee doesn't support checking links recursively from a web page; # but we do have a kind of sitemap here that we can pass to it. cd tanstack-table/docs/ lychee $(find . -name '*.md' | sed 's~./~https://tanstack.com/table/latest/docs/~;s/.md//') # for the local build; might also want `--timeout 60` lychee $(find . -name '*.md' | sed 's~./~http://localhost:3000/table/latest/docs/~;s/.md//') # sed's separator in 's/from/to/' can be changed to avoid escaping, # so 's~from~to~' has the same effect except slashes can stay as-is. # then s/.md// gets rid of the extension, completing the conversion # to deployed URLs. # (I'm explaining all this because I'm also scared by the xz takeover.) There is some magic with relative links: "../" seems to navigate to "../../" instead (???), while ./ is the current path. As a result every replacement here is manually done and tested with lychee. Exceptional cases are explained in the details section below. When checking the result afterwards, there may be one broken link left if locally only the /tanstack/tanstack.com and /tanstack/table repositories are checked out: from localhost:3000/table/latest/docs/guide/virtualization, linking to localhost:3000/virtual/v3/docs/api/virtualizer. This is an artifact of the way it's checked out. Detailed changes: docs/api/core/{cell,column,header-group,header,row,table}: link to /docs/guide/features currently link to /guide/features instead, and causes a redirect loop. This error is deployed right now: check eg. https://tanstack.com/table/latest/docs/api/core/cell and click the "table features" link. (This is not exceptional, just the first case I tackled.) docs/guide/headers: Aside from fixing paths, also fix an incorrect reference to non-existant Column Resizing Guide at docs/guide/column-resizing; presumably this is misspelling for the Column Sizing Guide at docs/guide/column-sizing. docs/guide/row-selection: Beyond fixing paths, also fix a missing /example/ in the vue example path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update column filtering pagination guide link since it does not exist anymore