Skip to content

Conversation

@LadyBluenotes
Copy link
Contributor

@LadyBluenotes LadyBluenotes commented Sep 17, 2025

  • Update img responsiveness

Summary by CodeRabbit

  • Documentation
    • Removed the “Become a Sponsor!” callout from the README.
    • Updated the Partners section with theme-aware logos (light/dark) for Coderabbit, Cloudflare, and AG Grid.
    • Standardized logo sizes: 40px (Coderabbit) and 60px (Cloudflare, AG Grid) for visual consistency.
    • Improved readability and appearance across light/dark themes.

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Walkthrough

Updated README.md by removing the sponsor callout and reworking the Partners section to use color-scheme-aware picture elements with dark/light logo sources for Coderabbit, Cloudflare, and AG Grid, adjusting logo heights and referencing local media assets where applicable.

Changes

Cohort / File(s) Summary of changes
Documentation & Branding
README.md
Removed sponsor callout. Replaced static logos with picture elements using dark/light sources for Coderabbit (coderabbit-dark-CMcuvjEy.svg, coderabbit-light-DVMJ2jHi.svg), Cloudflare (cloudflare-white-DQDB7UaL.svg, cloudflare-black-CPufaW0B.svg), and AG Grid (ag-grid-dark.svg, ag-grid-light.svg, local media). Set heights: 40px (Coderabbit), 60px (Cloudflare, AG Grid). Added theming support in Partners section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Update README #6096 — Also updates README Partners/sponsor area, including partner logos and sponsor callout adjustments.

Suggested reviewers

  • KevinVandy

Poem

I nibbled the README, hop-hop, neat—
Swapped sunny logos for moonlit fleet.
Pictures that shimmer in day and night,
Partners aligned at the perfect height.
Sponsor carrot gone from the top—
Theming blooms; thump-thump—ship it, hop! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Readme img fix" is short and directly related to the README image changes in the diff (logo replacements and responsiveness/height adjustments), so it conveys the primary intent of the PR; however it is somewhat generic and does not mention the theming or partner-logo updates specifically.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
README.md (5)

67-69: Remove invalid height attributes from elements.

The height attribute isn’t valid on and is ignored. Keep sizing on the or via CSS.

Apply this diff:

-			  <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-CMcuvjEy.svg" height="40" />
-			  <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" height="40" />
+			  <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-CMcuvjEy.svg" />
+			  <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" />
@@
-		  <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-DQDB7UaL.svg" height="60" />
-		  <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" />
+		  <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-DQDB7UaL.svg" />
+		  <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" />
@@
-        <source media="(prefers-color-scheme: dark)" srcset="./media/ag-grid-dark.svg" height="40" />
-        <source media="(prefers-color-scheme: light)" srcset="./media/ag-grid-light.svg" height="40" />
+        <source media="(prefers-color-scheme: dark)" srcset="./media/ag-grid-dark.svg" />
+        <source media="(prefers-color-scheme: light)" srcset="./media/ag-grid-light.svg" />

Also applies to: 76-78, 85-87


64-64: Use valid padding on and standardize across cells.

HTML doesn’t support a padding attribute on . Use inline style (or CSS) and keep spacing consistent.

Apply this diff:

-    <td>
+    <td style="padding: 20px;">
@@
-    <td padding="20">
+    <td style="padding: 20px;">
@@
-    <td>
+    <td style="padding: 20px;">

Also applies to: 73-73, 82-82


66-71: Replace hard tabs with spaces (markdownlint MD010).

Linter flags tabs here. Replace with spaces to satisfy rules and keep indentation consistent.

Apply this diff (showing leading whitespace only):

-			<picture>
-			  <source ...
-			  <source ...
-			  <img ...
-			</picture>        
-		</a>
+      <picture>
+        <source ...
+        <source ...
+        <img ...
+      </picture>
+    </a>
@@
-         <picture>
-		  <source ...
-		  <source ...
-		  <img ...
-		</picture>
+         <picture>
+          <source ...
+          <source ...
+          <img ...
+        </picture>

Also applies to: 76-79


85-88: Unify AG Grid fallback asset and keep it local.

Fallback points to raw.githubusercontent.com while sources use ./media. Prefer a local fallback for reliability and to avoid mixed domains.

Apply this diff:

-        <img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" />
+        <img src="./media/ag-grid-light.svg" height="60" alt="AG Grid" />

69-69: Optional: defer offscreen image loading.

Add loading="lazy" to logos to trim initial payload in README renderers that honor it.

Apply this diff:

-			  <img src="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" height="40" alt="CodeRabbit" />
+			  <img src="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" height="40" loading="lazy" alt="CodeRabbit" />
@@
-		  <img src="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" alt="Cloudflare" />
+		  <img src="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" loading="lazy" alt="Cloudflare" />
@@
-        <img src="./media/ag-grid-light.svg" height="60" alt="AG Grid" />
+        <img src="./media/ag-grid-light.svg" height="60" loading="lazy" alt="AG Grid" />

Also applies to: 78-78, 87-87

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 707aa7b and 81b2439.

⛔ Files ignored due to path filters (2)
  • media/ag-grid-dark.svg is excluded by !**/*.svg
  • media/ag-grid-light.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md

66-66: Hard tabs
Column: 1

(MD010, no-hard-tabs)


67-67: Hard tabs
Column: 1

(MD010, no-hard-tabs)


68-68: Hard tabs
Column: 1

(MD010, no-hard-tabs)


69-69: Hard tabs
Column: 1

(MD010, no-hard-tabs)


70-70: Hard tabs
Column: 1

(MD010, no-hard-tabs)


71-71: Hard tabs
Column: 1

(MD010, no-hard-tabs)


76-76: Hard tabs
Column: 1

(MD010, no-hard-tabs)


77-77: Hard tabs
Column: 1

(MD010, no-hard-tabs)


78-78: Hard tabs
Column: 1

(MD010, no-hard-tabs)


79-79: Hard tabs
Column: 1

(MD010, no-hard-tabs)

🔇 Additional comments (1)
README.md (1)

63-91: Good upgrade to theme-aware partner logos.

Using with dark/light sources improves readability across color schemes.

@KevinVandy KevinVandy merged commit 569a6e8 into TanStack:main Sep 17, 2025
2 checks passed
@LadyBluenotes LadyBluenotes deleted the readme branch September 17, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants