fix: relative pathing for markdown links #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SeanCassiere
changed the title
react-compiler
it doesn't really matter, but i might as well do the "correct" thing
it seems outside the scope of this PR
SeanCassiere
changed the title
react-compiler
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
* fix: complex handling of relative pathing * fix: handle cases without `../` or `./` * refactor: simplify the spaghetti * feat: add react-compiler * fix: handle markdown only having a hash * fix: don't replace the existing hash * refactor: move the component export to the top * fix: use pathname not href it doesn't really matter, but i might as well do the "correct" thing * fix: more edge case handling * fix: handle absolute urls * chore: remove react-compiler it seems outside the scope of this PR --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we handle relative pathing in the markdown from the libraries using a simple regex replace. This doesn't handle edge cases like what Form currently has with its reference page.
This function essentially correctly translates the markdown relative navigation onto the URL bar.