Skip to content

Conversation

@dborysov
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 11, 2025 17:03
@netlify
Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit d7e9492
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/689a224c6994c2000833d165
😎 Deploy Preview https://deploy-preview-462--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29 (🔴 down 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 83 (no change from production)
SEO: 95 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the img component in the Markdown component to properly handle className props by merging them with default styling classes.

  • Modified the img component to accept and merge additional className props with existing default styles

className="max-w-full h-auto rounded-lg shadow-md"
className={`max-w-full h-auto rounded-lg shadow-md ${
props.className ?? ''
}`}
Copy link

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The template literal with line breaks makes the className construction harder to read and maintain. Consider using a utility function like clsx or cn for cleaner class merging, or format it as a single line.

Copilot uses AI. Check for mistakes.
Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there anywhere where this specifically affected the content on the website?

@dborysov
Copy link
Contributor Author

Was there anywhere where this specifically affected the content on the website?

Yes, here the browsers´ logos are not properly styled - should be inlined (like here)

I searched other places and <img> is only used in a couple of README files, where class is not used. Can you think about any cases where this change can be dangerous?

Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SeanCassiere SeanCassiere merged commit bbd27a6 into TanStack:main Aug 13, 2025
6 checks passed
KyleAMathews pushed a commit to KyleAMathews/tanstack.com that referenced this pull request Nov 12, 2025
LeCarbonator pushed a commit to LeCarbonator/tanstack.com that referenced this pull request Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants