-
-
Notifications
You must be signed in to change notification settings - Fork 268
fix: enhance img component className handling #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the img component in the Markdown component to properly handle className props by merging them with default styling classes.
- Modified the img component to accept and merge additional className props with existing default styles
| className="max-w-full h-auto rounded-lg shadow-md" | ||
| className={`max-w-full h-auto rounded-lg shadow-md ${ | ||
| props.className ?? '' | ||
| }`} |
Copilot
AI
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The template literal with line breaks makes the className construction harder to read and maintain. Consider using a utility function like clsx or cn for cleaner class merging, or format it as a single line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there anywhere where this specifically affected the content on the website?
Yes, here the browsers´ logos are not properly styled - should be inlined (like here) I searched other places and |
SeanCassiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!

No description provided.