fix: counters in the homepage no longer disappear on first load#465
Merged
tannerlinsley merged 3 commits intoTanStack:mainfrom Aug 23, 2025
Merged
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@erquhart quick review here? My "hotfix" did cause cls from having no fallback in the suspense boundary. This pr seems to fix that |
KevinVandy
approved these changes
Aug 19, 2025
Contributor
|
@Balastrong @KevinVandy looks like this is still happening, I'm working on a fix. |
KyleAMathews
pushed a commit
to KyleAMathews/tanstack.com
that referenced
this pull request
Nov 12, 2025
…tack#465) Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com> Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
…tack#465) Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com> Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still have the counters in the homepage disappearing for a second right after the first load. No errors are thrown but the component still suspends and our fallback is an empty component.
Preloading the data will prevent the component from suspending right after mount.
While waiting for the current behaviour to be fixed upstream (see erquhart/convex-oss-stats#7 and get-convex/convex-react-query#22) this could be a nice temporary fix