Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions agents/tasks/code-splitting-fixes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
## Code-splitting cleanup (TanStack Router warnings)

Fix: Remove named exports from route files so they can be code-split. If symbols are needed elsewhere, move them to a non-route module (e.g., `src/components/` or `src/routes/_shared/`) and import locally.

Checklist

- [x] `src/routes/$libraryId/route.tsx`: remove export of `RouteForm`
- [x] `src/routes/_libraries/terms.tsx`: remove export of `RouteComp`
- [x] `src/routes/_libraries/privacy.tsx`: remove export of `RouteComp`
- [x] `src/routes/_libraries/partners.tsx`: remove export of `RouteComp`
- [x] `src/routes/_libraries/ethos.tsx`: remove export of `RouteComp`
- [x] `src/routes/_libraries/brand-guide.tsx`: remove export of `RouteComponent`
- [x] `src/routes/_libraries/blog.$.tsx`: remove export of `BlogPost`
- [x] `src/routes/_libraries/virtual.$version.index.tsx`: remove export of `RouteComp`
- [x] `src/routes/_libraries/table.$version.index.tsx`: remove export of `TableVersionIndex`
- [x] `src/routes/_libraries/store.$version.index.tsx`: remove export of `StoreVersionIndex`
- [x] `src/routes/_libraries/start.$version.index.tsx`: remove export of `VersionIndex`
- [x] `src/routes/_libraries/ranger.$version.index.tsx`: remove export of `VersionIndex`
- [x] `src/routes/_libraries/query.$version.index.tsx`: remove export of `VersionIndex`
- [x] `src/routes/_libraries/pacer.$version.index.tsx`: remove export of `PacerVersionIndex`
- [x] `src/routes/_libraries/form.$version.index.tsx`: remove export of `FormVersionIndex`
- [x] `src/routes/_libraries/devtools.$version.index.tsx`: remove export of `DevtoolsVersionIndex`
- [x] `src/routes/_libraries/db.$version.index.tsx`: remove export of `DBVersionIndex`
- [x] `src/routes/_libraries/config.$version.index.tsx`: remove export of `FormVersionIndex`

Notes

- If any of the above symbols are imported from other modules, migrate them to a non-route file and re-import locally.
- After edits, run the build and ensure warnings are gone.

Open issue

- [x] `TypeError: (intermediate value).routerEntry.getRouter is not a function` → Verified router export and build succeeded

Additional

- Updated `src/server/sponsors.ts` to use `setResponseHeaders` API for headers.
7 changes: 5 additions & 2 deletions netlify.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
[context.production]
command = "npx convex deploy --cmd 'pnpm run build'"
command = "npx convex deploy --cmd 'pnpm run build'"
[context.deploy-preview]
command = "npx convex deploy --cmd 'pnpm run build' --preview-run 'stats:sync'"
command = "npx convex deploy --cmd 'pnpm run build'"
[build]
command = "vite build"
publish = "dist/client"
17 changes: 8 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,29 @@
"@erquhart/convex-oss-stats": "^0.8.1",
"@floating-ui/react": "^0.27.8",
"@headlessui/react": "1.7.18",
"@netlify/vite-plugin-tanstack-start": "^1.0.2",
"@number-flow/react": "^0.4.1",
"@observablehq/plot": "^0.6.17",
"@octokit/graphql": "^7.0.2",
"@octokit/rest": "^20.0.2",
"@orama/react-components": "^0.1.23",
"@radix-ui/react-dropdown-menu": "^2.1.12",
"@radix-ui/react-toast": "^1.2.2",
"@radix-ui/react-select": "^2.2.2",
"@radix-ui/react-toast": "^1.2.2",
"@remix-run/node": "^2.8.1",
"@sentry/react": "^8.35.0",
"@sentry/vite-plugin": "^2.22.6",
"@tailwindcss/typography": "^0.5.13",
"@tailwindcss/vite": "^4.1.11",
"@tanstack/react-pacer": "^0.7.0",
"@tanstack/react-query": "^5.84.2",
"@tanstack/react-router": "1.131.27",
"@tanstack/react-router-devtools": "1.131.27",
"@tanstack/react-pacer": "^0.16.3",
"@tanstack/react-query": "^5.90.2",
"@tanstack/react-router": "1.132.47",
"@tanstack/react-router-devtools": "1.132.51",
"@tanstack/react-router-with-query": "1.130.17",
"@tanstack/react-start": "1.131.27",
"@tanstack/react-start": "1.132.51",
"@tanstack/react-table": "^8.21.3",
"@types/d3": "^7.4.3",
"@typescript-eslint/parser": "^7.2.0",
"@vercel/analytics": "^1.2.2",
"@vercel/speed-insights": "^1.0.10",
"@visx/hierarchy": "^2.10.0",
"@visx/responsive": "^2.10.0",
"@vitejs/plugin-react": "^4.3.3",
Expand Down Expand Up @@ -104,7 +103,7 @@
"prettier": "^2.8.8",
"tailwindcss": "^4.1.11",
"typescript": "^5.6.3",
"vite": "^6.3.5"
"vite": "^7.0.0"
},
"engines": {
"node": ">=18.0.0"
Expand Down
4,058 changes: 2,087 additions & 1,971 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/components/DocsLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@
import {
Link,
useMatches,
useNavigate,

Check warning on line 13 in src/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'useNavigate' is defined but never used
useParams,
} from '@tanstack/react-router'
import { Select } from '~/components/Select'

Check warning on line 16 in src/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'Select' is defined but never used
import { useLocalStorage } from '~/utils/useLocalStorage'
import { last } from '~/utils/utils'
import type { SelectOption } from '~/components/Select'

Check warning on line 19 in src/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'SelectOption' is defined but never used
import type { ConfigSchema, MenuItem } from '~/utils/config'
import { create } from 'zustand'

Check warning on line 21 in src/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'create' is defined but never used
import { Framework, getFrameworkOptions } from '~/libraries'

Check warning on line 22 in src/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'getFrameworkOptions' is defined but never used
import { DocsCalloutQueryGG } from '~/components/DocsCalloutQueryGG'
import { DocsCalloutBytes } from '~/components/DocsCalloutBytes'
import { twMerge } from 'tailwind-merge'
Expand Down Expand Up @@ -222,6 +222,7 @@
</a>
) : (
<Link
from="/$libraryId/$version/docs"
to={child.to}
params
onClick={() => {
Expand Down
10 changes: 5 additions & 5 deletions src/components/ThemeProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ScriptOnce } from '@tanstack/react-router'
import { clientOnly, createIsomorphicFn } from '@tanstack/react-start'
import { createClientOnlyFn, createIsomorphicFn } from '@tanstack/react-start'
import * as React from 'react'
import { createContext, ReactNode, useEffect, useState } from 'react'
import { z } from 'zod'
Expand All @@ -22,7 +22,7 @@ const getStoredThemeMode = createIsomorphicFn()
}
})

const setStoredThemeMode = clientOnly((theme: ThemeMode) => {
const setStoredThemeMode = createClientOnlyFn((theme: ThemeMode) => {
try {
const parsedTheme = themeModeSchema.parse(theme)
localStorage.setItem(themeKey, parsedTheme)
Expand All @@ -37,7 +37,7 @@ const getSystemTheme = createIsomorphicFn()
: 'light'
})

const updateThemeClass = clientOnly((themeMode: ThemeMode) => {
const updateThemeClass = createClientOnlyFn((themeMode: ThemeMode) => {
const root = document.documentElement
root.classList.remove('light', 'dark', 'auto')
const newTheme = themeMode === 'auto' ? getSystemTheme() : themeMode
Expand All @@ -48,14 +48,14 @@ const updateThemeClass = clientOnly((themeMode: ThemeMode) => {
}
})

const setupPreferredListener = clientOnly(() => {
const setupPreferredListener = createClientOnlyFn(() => {
const mediaQuery = window.matchMedia('(prefers-color-scheme: dark)')
const handler = () => updateThemeClass('auto')
mediaQuery.addEventListener('change', handler)
return () => mediaQuery.removeEventListener('change', handler)
})

const getNextTheme = clientOnly((current: ThemeMode): ThemeMode => {
const getNextTheme = createClientOnlyFn((current: ThemeMode): ThemeMode => {
const themes: ThemeMode[] =
getSystemTheme() === 'dark'
? ['auto', 'light', 'dark']
Expand Down
Loading
Loading