Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual-core): ensure getTotalSize returns 0 for empty list #836

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

lucasweng
Copy link
Contributor

Copy link

nx-cloud bot commented Sep 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d1da8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 16, 2024

Open in Stackblitz

More templates

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@836

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@836

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@836

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@836

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@836

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@836

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@836

commit: 5d1da8e

@piecyk piecyk merged commit 9f8ac01 into TanStack:main Sep 16, 2024
5 checks passed
@lucasweng lucasweng deleted the fix/negative-total-size branch September 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getTotalSize reports a negative value for empty list when scrollMargin is set
2 participants