Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update svelte-virtual peerDependencies to allow for v5 #863

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

nigel-dev
Copy link
Contributor

Svelte v5 was just released and is backward compatible with v4. This updates the peerDependencies to allow for those running Svelte 5 projects to pull in this dependency.

For reference:
https://svelte.dev/blog/svelte-5-is-alive

Copy link

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's safe to remove v3 as peer dep. What do you think?

@nigel-dev
Copy link
Contributor Author

I believe it's safe to remove v3 as peer dep. What do you think?

I can do that, just didnt want to break anyone who might be still using version 3.

@rayrw rayrw mentioned this pull request Oct 28, 2024
2 tasks
@piecyk
Copy link
Collaborator

piecyk commented Oct 28, 2024

I believe it's safe to remove v3 as peer dep. What do you think?

I can do that, just didnt want to break anyone who might be still using version 3.

that is good question, maybe let's leave the v3 for now.

Copy link

nx-cloud bot commented Oct 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 209dd02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 28, 2024

Open in Stackblitz

More templates

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@863

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@863

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@863

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@863

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@863

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@863

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@863

commit: 209dd02

@nigel-dev
Copy link
Contributor Author

nigel-dev commented Oct 31, 2024

@piecyk
@wobsoriano

So add v3 support back?

@piecyk
Copy link
Collaborator

piecyk commented Nov 3, 2024

@piecyk @wobsoriano

So add v3 support back?

Yep if it works with v3 don't see any reason to remove it.

…ncy"

This reverts commit 771615e.

As per discussion v3 should remain.
@piecyk piecyk merged commit 5b2c2d6 into TanStack:main Nov 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants