-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update svelte-virtual peerDependencies to allow for v5 #863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's safe to remove v3 as peer dep. What do you think?
I can do that, just didnt want to break anyone who might be still using version 3. |
that is good question, maybe let's leave the v3 for now. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 209dd02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
So add v3 support back? |
Yep if it works with v3 don't see any reason to remove it. |
…ncy" This reverts commit 771615e. As per discussion v3 should remain.
Svelte v5 was just released and is backward compatible with v4. This updates the peerDependencies to allow for those running Svelte 5 projects to pull in this dependency.
For reference:
https://svelte.dev/blog/svelte-5-is-alive