-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#476 Import recipes with multiple instruction steps (for a custom Co… #1303
#476 Import recipes with multiple instruction steps (for a custom Co… #1303
Conversation
MarcusWolschon
commented
Jan 13, 2022
- Implement a custom scraper for Cookidoo with handling of stite specific formatings
- Implement the ability to manually or automatically import multi-step receipts by using the "Header 1" markdown
- automatically assign ingredients to the first step that mentions them when importing a multi step receipt
…or a custom Cookidoo scraper first)
i dont see how this respects what we have written in previous issues and in the discussion we had in discord ? How can the user quickly and easily decide if he wants to split steps or not ? What happens when i import from a page that gives me 25 steps? do i get 25 markdown headers ? how is this represented in the frontend? i do not see any changes to the importer UI ? |
You change it by choosing 'manual' after reviewing the preview and noticing that manual adjustment is needed and then editing the markdown before using the "import" button. It's currently only used for this one site that is known to have reasonable steps since the receipts there are not user supplied. (no json+ld offered for the user supplied receipts) |
I lack the expertise and insight to extend the preview page. That could be done on the feature branch before considering to merge this into the development branch or on the development branch after the next release is split off. I've done what I can do for this feature. |
…ctions for markdown usage
Improvements:
The Cookidoo importer is probably already pretty useful for many users without the changes to cookbook/templates/url_import.html and cookbook/views/data.py |
i will review this after my vacation and decide how we proceed |
…BLE_IMPORT_STEPS=1 similar to ENABLE_PDF_EXPORT=1
@vabene1111 I added an environment variable ENABLE_IMPORT_STEPS similar to ENABLE_PDF_EXPORT, so the experimental feature has to be explicitly enabled by the admin. |
closed for compliance reasons |