Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#476 import recipes with multiple steps + cookidoo importer #1389

Conversation

MarcusWolschon
Copy link
Contributor

Github doesn't update PRs with commits that are added to the branch after a PR is closed.
So here's a new one.
The Cookidoo importer is probably already pretty useful for many users without the changes to cookbook/templates/url_import.html and cookbook/views/data.py
That's easy to split off.

If you still feel the need to do this together with a complex javascript editor for steps in the import html page
or to combine import and recipe-edit pages forst. then I suggest a feature branch instead of develop, where such a revamp can be done.

Working:

  • User is instructed that manually added headers are converted into steps if and only if he/she chooses to via a checkbox.
  • Only a new scraper for the Cookidoo site (with curated recipes that don't feature excessive use of steps) generates these automatically for the time being.

Improvements:

  1. preview shows steps preformated
  2. preview and preview-editing shows a text about the use of markdown
  3. added a checkbox during import to enable the creation of steps similar to "all keywords"
  4. text of the header is used as the name of the step
  5. localised default step names for English and German
  6. Added unit test case for the "cookidoo" scraper,
  7. improved the translations
  8. added the ability to work with complex receips that have grouped steps. (generating not only level 1 but also level 2,... headers in the instructions)
  9. fixed support for cookidoo.at and cookidoo.ch in the cookidoo scraper
    grafik

@vabene1111
Copy link
Collaborator

sorry, as discussed i will close this. Feel free to merge this into your own build

@vabene1111 vabene1111 closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants