Merge pull request #6 from TangibleInc/no-sourcemaps-for-production

Generate source maps during development only and remove from production release

commands/build.js

@@ -3,6 +3,7 @@
  */
 
 const path = require('path')
+const fs = require('fs/promises')
 const rollup = require('rollup')
 const getFileSize = require('../utils/getFileSize')
 const displayError = require('../utils/displayError')
@@ -15,7 +16,7 @@ async function build(props) {
     return await inputOptions.build(props)
   }
 
-  const { cwd, rootDir } = config
+  const { cwd, rootDir, isDev } = config
 
   console.log('..Building from', path.relative(cwd, inputOptions.input))
 
@@ -41,6 +42,13 @@ async function build(props) {
     // , 'in', (duration / 1000).toFixed(2)+'s'
     `(${fileSize})`
   )
+
+  if (task.map === 'dev') {
+    // Remove source maps for production
+    await fs.rm(`${builtFile}.map`, {
+      force: true, // exceptions will be ignored if path does not exist
+    })
+  }
 }
 
 module.exports = build

config/index.js

@@ -115,8 +115,15 @@ async function createConfig({ commandName, subproject }) {
     lint,
     serve,
     archive,
+    map = 'dev' // Global default, can override per task
   } = configJson instanceof Function ? await configJson() : configJson
 
+  for (const task of tasks) {
+    if (typeof task.map==='undefined') {
+      task.map = map
+    }
+  }
+
   // Ensure project dependencies are installed
   if (
     Object.keys(dependencies).length > 0 &&

task/index.js

@@ -57,7 +57,12 @@ function createTaskConfigs({ config, task }) {
       task.task === 'sass'
         ? task.dest + '.tmp' // PostCSS emits its own file
         : task.dest,
-    sourcemap: task.task === 'sass' ? false : task.map !== false, // true by default
+    sourcemap: task.task === 'sass'
+      ? false
+      : task.map === 'dev' // See ../config for global default
+        ? isDev // Only during development
+        : task.map !== false
+    ,
 
     // Use default source map name to support dynamic exports and code splitting
     // sourcemapFile: task.dest + '.map',

test/tangible.config.js

@@ -3,7 +3,8 @@ module.exports = {
     {
       src: 'src/index.jsx',
       dest: 'build/test.min.js',
-      react: 'react'
+      react: 'react',
+      map: true, // Test override global default (source map during development only, remove for production)
     },
     {
       src: 'src/index.jsx',
@@ -40,7 +41,6 @@ module.exports = {
     async function({ config, task = {} }) {
       console.log('Custom build function')
     }
-
   ],
   format: 'src',
   serve: {