Fix default TypeScript export definition to conform to version 2.6.0 rules #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forbidden arbitrary expressions in export assignments in ambient contexts
tyronedougherty
commented
Apr 5, 2018
| @@ -192,7 +192,9 @@ declare var api: { | |||
| }; | |||
| tickPeriod: { | |||
| get(name: string, settings?: { utc?: boolean }): { cast: (d: Date) => Date; next: (d: Date) => Date; }; | |||
| add(name: string, period: { cast: (d: Date) => Date; next: (d: Date) => Date; }, settings?: { utc?: boolean }): void; | |||
There was a problem hiding this comment.
This line was too long according to the tslint.json file (120 characters max)
|
@tyronedougherty thank you for pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Please see issue here: #519
Changes made
package-lock.jsonfile so that its version number correctly matches that of thepackage.jsontypes/index.d.tsfile so that it correctly conforms to the rules outlined in thetslint.jsonfiletypes/index.d.tsto ensure that it is not an arbitrary expression, as this is a breaking change in TypeScript 2.6 - https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#arbitrary-expressions-are-forbidden-in-export-assignments-in-ambient-contexts