Skip to content

Comments

CLAP-376 수정 요구 Chloe#161

Merged
Minkyu0424 merged 5 commits intoreleasefrom
CLAP-376
Feb 11, 2025
Merged

CLAP-376 수정 요구 Chloe#161
Minkyu0424 merged 5 commits intoreleasefrom
CLAP-376

Conversation

@BaekJiyeon02
Copy link
Member

#️⃣연관된 티켓 넘버

CLAP-345
CLAP-376

📝작업 내용

오타, 용어에 대한 수정
비밀번호 조건은 맞지 않지만 확인 값과 동일한 경우에는 경고 메시지가 뜨지 않음
이미지 파일 유효성 검증 추가
알림 없을 시 경고 메시지
유효성 검증에 이모지 추가 및 경고 메시지 겹침 이슈 수정

🏞️스크린샷 (선택)

💬리뷰 요구사항(선택)

@BaekJiyeon02 BaekJiyeon02 added 🐞 BugFix Something isn't working 🔨 Refactor 코드 리팩토링 labels Feb 11, 2025
@BaekJiyeon02 BaekJiyeon02 changed the title CLAP-376 CLAP-376 수정 요구 Chloe Feb 11, 2025
@BaekJiyeon02 BaekJiyeon02 changed the base branch from develop to release February 11, 2025 08:59
@BaekJiyeon02 BaekJiyeon02 self-assigned this Feb 11, 2025
Copy link
Contributor

@Minkyu0424 Minkyu0424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 👏

previewUrl.value = URL.createObjectURL(selectedFile.value)
const file = target.files[0]

const allowedMimeTypes = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 constants로 빼서 파일유효성 하는곳에서 요긴하게 쓰일거같아요

@Minkyu0424 Minkyu0424 merged commit 0ba3d61 into release Feb 11, 2025
@Minkyu0424 Minkyu0424 deleted the CLAP-376 branch February 11, 2025 16:55
@BaekJiyeon02 BaekJiyeon02 linked an issue Feb 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLAP-376 수정 요구 Chloe

2 participants